From: Ingo Molnar <mingo@elte.hu>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: davej@codemonkey.org.uk, linux-kernel@vger.kernel.org,
cpufreq@vger.kernel.org
Subject: Re: [PATCH] cpufreq: Change link order of x86 cpufreq modules
Date: Wed, 18 Feb 2009 19:31:37 +0100 [thread overview]
Message-ID: <20090218183137.GD26802@elte.hu> (raw)
In-Reply-To: <20090218182822.GA19902@srcf.ucam.org>
* Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> Change the link order of the cpufreq modules to ensure that they're
> probed in the preferred order when statically linked in.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
>
> diff --git a/arch/x86/kernel/cpu/cpufreq/Makefile b/arch/x86/kernel/cpu/cpufreq/Makefile
> index 560f776..509296d 100644
> --- a/arch/x86/kernel/cpu/cpufreq/Makefile
> +++ b/arch/x86/kernel/cpu/cpufreq/Makefile
> @@ -1,6 +1,11 @@
> +# Link order matters. K8 is preferred to ACPI because of firmware bugs in early
> +# K8 systems. ACPI is preferred to all other hardware-specific drivers.
> +# speedstep-* is preferred over p4-clockmod.
Nice fix! Where does this information come from? Distro module
ordering magic? It's rather non-trivial.
(small style nit: the first line in the Makefile is overlong.)
Ingo
next prev parent reply other threads:[~2009-02-18 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 18:28 [PATCH] cpufreq: Change link order of x86 cpufreq modules Matthew Garrett
2009-02-18 18:31 ` Ingo Molnar [this message]
2009-02-18 18:34 ` Dave Jones
2009-02-18 18:36 ` Matthew Garrett
2009-02-18 19:09 ` Ingo Molnar
2009-02-19 11:54 ` Alan Jenkins
2009-02-19 12:03 ` Ingo Molnar
2009-02-23 21:12 ` Thomas Renninger
2009-02-23 21:47 ` Kay Sievers
2009-02-20 17:29 ` Scott James Remnant
2009-02-20 17:36 ` Matthew Garrett
2009-02-20 17:39 ` Scott James Remnant
2009-02-20 17:41 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218183137.GD26802@elte.hu \
--to=mingo@elte.hu \
--cc=cpufreq@vger.kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.