From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758161AbZBRWrd (ORCPT ); Wed, 18 Feb 2009 17:47:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756995AbZBRWcG (ORCPT ); Wed, 18 Feb 2009 17:32:06 -0500 Received: from kroah.org ([198.145.64.141]:34829 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757871AbZBRWcB (ORCPT ); Wed, 18 Feb 2009 17:32:01 -0500 Date: Wed, 18 Feb 2009 14:29:17 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Mike Christie , James Bottomley , Jean Delvare Subject: [patch 11/36] SCSI: libiscsi: fix iscsi pool leak Message-ID: <20090218222917.GL10668@kroah.com> References: <20090218222447.432108614@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="scsi-libiscsi-fix-iscsi-pool-leak.patch" In-Reply-To: <20090218222841.GA10668@kroah.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.27-stable review patch. If anyone has any objections, please let us know. ------------------ From: Mike Christie commit 2f5899a39dcffb404c9a3d06ad438aff3e03bf04 upstream. I am not sure what happened. It looks like we have always leaked the q->queue that is allocated from the kfifo_init call. nab finally noticed that we were leaking and this patch fixes it by adding a kfree call to iscsi_pool_free. kfifo_free is not used per kfifo_init's instructions to use kfree. Signed-off-by: Mike Christie Signed-off-by: James Bottomley Cc: Jean Delvare Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/libiscsi.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -1844,6 +1844,7 @@ void iscsi_pool_free(struct iscsi_pool * kfree(q->pool[i]); if (q->pool) kfree(q->pool); + kfree(q->queue); } EXPORT_SYMBOL_GPL(iscsi_pool_free);