From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Nigel Magnay <nigel.magnay@gmail.com>, Git ML <git@vger.kernel.org>
Subject: Re: [JGIT PATCH] 1/2 : (reworked) Externalizable/Serializable Items
Date: Thu, 19 Feb 2009 00:21:33 +0100 [thread overview]
Message-ID: <200902190021.33382.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20090218214859.GN22848@spearce.org>
onsdag 18 februari 2009 22:48:59 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> > Shawn wrote:
> > > > + os.writeUTF(KEY_FETCH);
> > > > + os.writeUTF(refspec.toString());
> > > > + }
> > > > +
> > > > + for (RefSpec refspec : push) {
> > > > + os.writeUTF(KEY_PUSH);
> > > > + os.writeUTF(refspec.toString());
> > > > + }
> > >
> > > Should we maybe allow RefSpec to serialize itself with
> > > os.writeObject() rather than using writeUTF() directly?
> >
> > Doesn't the style above make it easy to define and document
> > a format that is easy for non-java programs to write and read,
> > while writeObject introduces java-centric stuff (depending on
> > the full class name etc).
>
> Non-Java reading a Java serialization stream? Seriously?
No, that was my objection to using writeObject, as that make
it a Java-only stream, but then it might not be worth doing
it via the serialization mechanism.
-- robin
next prev parent reply other threads:[~2009-02-18 23:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 20:12 [JGIT PATCH] 1/2 : (reworked) Externalizable/Serializable Items Nigel Magnay
2009-02-16 20:16 ` Johannes Schindelin
2009-02-18 16:30 ` Shawn O. Pearce
2009-02-18 20:59 ` Robin Rosenberg
2009-02-18 21:48 ` Shawn O. Pearce
2009-02-18 22:19 ` Sverre Rabbelier
2009-02-18 23:21 ` Robin Rosenberg [this message]
2009-02-18 23:27 ` Shawn O. Pearce
[not found] ` <320075ff0902200127m3e516621m60a608bc891ab992@mail.gmail.com>
2009-02-20 9:28 ` Nigel Magnay
2009-02-20 20:32 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902190021.33382.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=nigel.magnay@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.