From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ovro.ovro.caltech.edu (ovro.ovro.caltech.edu [192.100.16.2]) by ozlabs.org (Postfix) with ESMTP id D1E4FDDE06 for ; Fri, 20 Feb 2009 04:03:16 +1100 (EST) Date: Thu, 19 Feb 2009 09:03:14 -0800 From: Ira Snyder To: Kumar Gala Subject: Re: [RFC v1] virtio: add virtio-over-PCI driver Message-ID: <20090219170313.GC12795@ovro.caltech.edu> References: <20090217222425.GA18801@ovro.caltech.edu> <7DF0AF56456B8F4081E3C44CCCE311DE1519A3@zch01exm23.fsl.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: Arnd Bergmann , Jan-Bernd Themann , netdev@vger.kernel.org, Rusty Russell , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Feb 19, 2009 at 10:51:43AM -0600, Kumar Gala wrote: > > On Feb 19, 2009, at 12:13 AM, Zang Roy-R61911 wrote: > >> >> >>> -----Original Message----- >>> From: >>> linuxppc-dev-bounces+tie-fei.zang=freescale.com@ozlabs.org >>> [mailto:linuxppc-dev-bounces+tie-fei.zang=freescale.com@ozlabs >>> .org] On Behalf Of Kumar Gala >>> Sent: Thursday, February 19, 2009 0:47 AM >>> To: Ira Snyder >>> Cc: Arnd Bergmann; Jan-Bernd Themann; netdev@vger.kernel.org; >>> Rusty Russell; linux-kernel@vger.kernel.org; linuxppc-dev@ozlabs.org >>> Subject: Re: [RFC v1] virtio: add virtio-over-PCI driver >>> >>> >>> On Feb 17, 2009, at 4:24 PM, Ira Snyder wrote: >>> >>>> >>>> Documentation/virtio-over-PCI.txt | 61 ++ >>>> arch/powerpc/boot/dts/mpc834x_mds.dts | 7 + >>> >>> we'll have to review the .dts and expect a documentation update for >>> the node. But that's pretty minor at this point. >>> >>>> drivers/virtio/Kconfig | 22 + >>>> drivers/virtio/Makefile | 2 + >>>> drivers/virtio/vop.h | 119 ++ >>>> drivers/virtio/vop_fsl.c | 1911 >>> ++++++++++++++++++++++++ >>>> +++++++++ >>> >>> make this vop_fsl_mpc83xx.c or something along those lines. >> why? > > so we can deal with 85xx as well. We just need to isolate the 83xx > specific bits (message usage) > In fact, most of the driver has nothing to do with hardware, and everything to do with managing memory. Most of the driver could be shared between implementations. The only things that would be hardware specific are setting up the descriptor memory, and raising/handling interrupts. I just wanted to get something working and out here to discuss. I figured that more hardware support, features, etc. could come later. Just like everything else in the kernel, I'm sure this will have to evolve over time as well. Thanks, Ira From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758559AbZBSRDa (ORCPT ); Thu, 19 Feb 2009 12:03:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753533AbZBSRDR (ORCPT ); Thu, 19 Feb 2009 12:03:17 -0500 Received: from ovro.ovro.caltech.edu ([192.100.16.2]:44124 "EHLO ovro.ovro.caltech.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbZBSRDQ (ORCPT ); Thu, 19 Feb 2009 12:03:16 -0500 Date: Thu, 19 Feb 2009 09:03:14 -0800 From: Ira Snyder To: Kumar Gala Cc: Zang Roy-R61911 , Arnd Bergmann , Jan-Bernd Themann , netdev@vger.kernel.org, Rusty Russell , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [RFC v1] virtio: add virtio-over-PCI driver Message-ID: <20090219170313.GC12795@ovro.caltech.edu> References: <20090217222425.GA18801@ovro.caltech.edu> <7DF0AF56456B8F4081E3C44CCCE311DE1519A3@zch01exm23.fsl.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (ovro.ovro.caltech.edu); Thu, 19 Feb 2009 09:03:15 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 19, 2009 at 10:51:43AM -0600, Kumar Gala wrote: > > On Feb 19, 2009, at 12:13 AM, Zang Roy-R61911 wrote: > >> >> >>> -----Original Message----- >>> From: >>> linuxppc-dev-bounces+tie-fei.zang=freescale.com@ozlabs.org >>> [mailto:linuxppc-dev-bounces+tie-fei.zang=freescale.com@ozlabs >>> .org] On Behalf Of Kumar Gala >>> Sent: Thursday, February 19, 2009 0:47 AM >>> To: Ira Snyder >>> Cc: Arnd Bergmann; Jan-Bernd Themann; netdev@vger.kernel.org; >>> Rusty Russell; linux-kernel@vger.kernel.org; linuxppc-dev@ozlabs.org >>> Subject: Re: [RFC v1] virtio: add virtio-over-PCI driver >>> >>> >>> On Feb 17, 2009, at 4:24 PM, Ira Snyder wrote: >>> >>>> >>>> Documentation/virtio-over-PCI.txt | 61 ++ >>>> arch/powerpc/boot/dts/mpc834x_mds.dts | 7 + >>> >>> we'll have to review the .dts and expect a documentation update for >>> the node. But that's pretty minor at this point. >>> >>>> drivers/virtio/Kconfig | 22 + >>>> drivers/virtio/Makefile | 2 + >>>> drivers/virtio/vop.h | 119 ++ >>>> drivers/virtio/vop_fsl.c | 1911 >>> ++++++++++++++++++++++++ >>>> +++++++++ >>> >>> make this vop_fsl_mpc83xx.c or something along those lines. >> why? > > so we can deal with 85xx as well. We just need to isolate the 83xx > specific bits (message usage) > In fact, most of the driver has nothing to do with hardware, and everything to do with managing memory. Most of the driver could be shared between implementations. The only things that would be hardware specific are setting up the descriptor memory, and raising/handling interrupts. I just wanted to get something working and out here to discuss. I figured that more hardware support, features, etc. could come later. Just like everything else in the kernel, I'm sure this will have to evolve over time as well. Thanks, Ira