From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2: set xh_free_start when xattr header in inode/block
Date: Thu, 19 Feb 2009 09:38:43 -0800 [thread overview]
Message-ID: <20090219173843.GC15753@ca-server1.us.oracle.com> (raw)
In-Reply-To: <499BB514.7020709@oracle.com>
On Wed, Feb 18, 2009 at 03:13:24PM +0800, Tiger Yang wrote:
> Hi, Joel and Mark,
>
> I suddenly found there might be a potential problem in this patch.
>
> If user setting EAs sometimes with .28 kernel and sometimes with .29
> kernel, xh_free_start will go stale. And fsck will make it worse.
>
> If this really a problem I withdraw this patch but I think the second patch
> is OK.
Tiger,
I think you are right. We're going to have to give up on
updating xh_free_start in inode/block. fsck will just have to try to
verify that the entrys and values don't overlap.
Please respin the second patch without the first, code up fsck
appropriately.
Joel
--
"Under capitalism, man exploits man. Under Communism, it's just
the opposite."
- John Kenneth Galbraith
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2009-02-19 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 7:38 [Ocfs2-devel] [PATCH 0/2] ocfs2: two fixes for xattr -v2 Tiger Yang
2009-02-16 7:43 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: set xh_free_start when xattr header in inode/block Tiger Yang
2009-02-18 7:13 ` Tiger Yang
2009-02-19 17:38 ` Joel Becker [this message]
2009-02-16 7:43 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: set gap to seperate entry and value when xattr in bucket Tiger Yang
-- strict thread matches above, loose matches on Subject: below --
2009-02-11 2:33 [Ocfs2-devel] [PATCH 0/2] ocfs2: two fixes for xattr Tiger Yang
2009-02-11 2:38 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: set xh_free_start when xattr header in inode/block Tiger Yang
2009-02-11 18:50 ` Joel Becker
2009-02-12 3:02 ` Tiger Yang
2009-02-13 23:03 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219173843.GC15753@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.