From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LaNkj-0008Sk-9W
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 00:16:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LaNkh-0008R2-IV
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 00:16:44 -0500
Received: from [199.232.76.173] (port=42465 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LaNkh-0008Qo-BN
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 00:16:43 -0500
Received: from mx20.gnu.org ([199.232.41.8]:14435)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <vladimir@codesourcery.com>)
	id 1LaNkh-0003dE-4w
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 00:16:43 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <vladimir@codesourcery.com>) id 1LaNkg-0000rW-37
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 00:16:42 -0500
From: Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [Qemu-devel] SH: Improve the interrupt controller
Date: Fri, 20 Feb 2009 08:16:46 +0300
References: <200812112252.17620.vladimir@codesourcery.com>
	<200902121405.34112.vladimir@codesourcery.com>
	<20090220030657.GB9141@game.jcrosoft.org>
In-Reply-To: <20090220030657.GB9141@game.jcrosoft.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200902200816.46866.vladimir@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: takasi-y@ops.dti.ne.jp, qemu-devel@nongnu.org

On Friday 20 February 2009 06:06:57 Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:05 Thu 12 Feb     , Vladimir Prus wrote:
> > On Sunday 08 February 2009 21:57:25 takasi-y@ops.dti.ne.jp wrote:
> > > Hi, Vladimir.
> > > 
> > > I managed to make the code working.
> > > r2d boot, SCI and CF working, and /proc/interrupts increases.
> > > 
> > > Essential points modified are below.
> > > 1. sh_intc_init() caller/callee mismatch.
> > > 2. nobody calls sh_intc_set_irl_priorities()
> > > 3. INTC_MODE_DUAL_SET/CLR swapped
> > > I'm not sure 3 in your patch is on purpose or not.
> > > 
> > > Attached patch is a diff against rev#6563.
> > > This is yours + my small fixes, which are..
> > > - Above three
> > > - sh_intc_set_irl_priorities() has switched to sh_intc_init_irl_priorities().
> > > - sh_intc_set_irl()'s enable hack removed.
> > > - indent,tab/space,brace changed (to what looks like code around)
> > > - reduce INTC_A7() usage
> > > - some others.
> > 
> > Hi Yoshii,
> > I have replaced my original patch with your patch in my patch set, and adjusted
> > sh7785 emulation for your changes. It works, but only after I re-do the
> where can we found this famous sh7785 patch set?

Only in my git tree, at the moment. There's one patch there that needs some
rework before it's posted.

- Volodya