Re: [PATCH] x86: enable x2apic early at the first point

[Gleb Natapov <gleb@redhat.com>]

On Fri, Feb 20, 2009 at 10:41:23AM +0100, Ingo Molnar wrote:
> 
> * Gleb Natapov <gleb@redhat.com> wrote:
> 
> > > > I will post couple of patches, which revert's Gleb's patch 
> > > > and another fix for the early boot failure issue, 
> > > > tomorrow.
> > 
> > If you'll revert my patch it will not be possible to use 
> > x2apic in KVM (at least without KVM implementing interrupt 
> > remapping which is unneeded otherwise) and x2apic interface is 
> > much better for vitalization. Instead of reverting the patch 
> > it will be better to add check if x2apic can be used without 
> > intr-remmaping (all CPUs belong to cluster 0) or allow 
> > enabling of x2apic without IR if running as a guest.
> 
> yep, that would be required - because your patch can break real 
> systems right now. Mind sending me a fix for it?
> 
> I've applied Yinghai's fix as well, so please base it on latest 
> tip:master.
> 
OK. Will send next week.

--
			Gleb.