From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] llc: fix non-const printk warning
Date: Fri, 20 Feb 2009 18:37:22 -0300 [thread overview]
Message-ID: <20090220213722.GB18285@ghostprotocols.net> (raw)
In-Reply-To: <20090220100206.533d59d4@extreme>
Em Fri, Feb 20, 2009 at 10:02:06AM -0800, Stephen Hemminger escreveu:
> Mark some strings as const.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Thanks,
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> --- a/net/llc/af_llc.c 2009-02-20 08:34:21.537870609 -0800
> +++ b/net/llc/af_llc.c 2009-02-20 08:37:52.920622312 -0800
> @@ -1118,11 +1118,11 @@ static const struct proto_ops llc_ui_ops
> .sendpage = sock_no_sendpage,
> };
>
> -static char llc_proc_err_msg[] __initdata =
> +static const char llc_proc_err_msg[] __initconst =
> KERN_CRIT "LLC: Unable to register the proc_fs entries\n";
> -static char llc_sysctl_err_msg[] __initdata =
> +static const char llc_sysctl_err_msg[] __initconst =
> KERN_CRIT "LLC: Unable to register the sysctl entries\n";
> -static char llc_sock_err_msg[] __initdata =
> +static const char llc_sock_err_msg[] __initconst =
> KERN_CRIT "LLC: Unable to register the network family\n";
>
> static int __init llc2_init(void)
> --
next prev parent reply other threads:[~2009-02-20 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 18:02 [PATCH 1/2] llc: fix non-const printk warning Stephen Hemminger
2009-02-20 18:03 ` [PATCH 2/2] snap: handle registration error and compile warning Stephen Hemminger
2009-02-20 21:37 ` Arnaldo Carvalho de Melo
2009-02-22 8:03 ` David Miller
2009-02-20 21:37 ` Arnaldo Carvalho de Melo [this message]
2009-02-22 8:02 ` [PATCH 1/2] llc: fix non-const printk warning David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090220213722.GB18285@ghostprotocols.net \
--to=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.