Re: [PATCH] input: keyboard: introduce lm8323 driver

[Felipe Balbi <me@felipebalbi.com>]

On Sat, Feb 21, 2009 at 12:29:12AM +0200, Felipe Balbi wrote:
> On Fri, Feb 20, 2009 at 02:15:05PM -0800, Andrew Morton wrote:
> > On Thu, 19 Feb 2009 14:31:17 +0200
> > Felipe Balbi <me@felipebalbi.com> wrote:
> > 
> > > +struct lm8323_platform_data {
> > > +	int debounce_time; /* Time to watch for key bouncing, in ms. */
> > > +	int active_time; /* Idle time until sleep, in ms. */
> > > +
> > > +	int size_x;
> > > +	int size_y;
> > > +	int repeat : 1;
> > 
> > lm8323_platform_data.repeat appears to be never-written-to?
> 
> Nobody is using that yet, still it's used in the driver:
> 	if (pdata->repeat)
> 		__set_bit(EV_REP, idev->evbit);
> 
> Also, those spaces around : should vanish. Want me to resend the whole
> patch or just a patch on top of it ?

well, I'm stopping for today (almost 1am), here's an update patch. If
you need me to resend the patch, I can do it when I wake up, just bug me
;-)

diff --git a/include/linux/i2c/lm8323.h b/include/linux/i2c/lm8323.h
index 37f819b..67e82bc 100644
--- a/include/linux/i2c/lm8323.h
+++ b/include/linux/i2c/lm8323.h
@@ -33,7 +33,7 @@ struct lm8323_platform_data {
 
        int size_x;
        int size_y;
-       int repeat : 1;
+       int repeat:1;
        const s16 *keymap;
 
        char *pwm1_name; /* Device name for PWM1. */

-- 
balbi