From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
donald.c.skidmore@intel.com, peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-next PATCH 2/2] ixgbe: fix for 82598 Si errata causing buffer overflow
Date: Sat, 21 Feb 2009 15:43:05 -0800 (PST) [thread overview]
Message-ID: <20090221.154305.237729082.davem@davemloft.net> (raw)
In-Reply-To: <20090221222339.6451.72721.stgit@lost.foo-projects.org>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sat, 21 Feb 2009 14:23:40 -0800
> The failure happens when an interrupt occurs and the driver is reading
> EICR. This read will cause a clear-by-read which leads to two TLP
> being inserted in the PCIe retry buffer leading to an overflow of the
> buffer and corruption of TLPs.
>
> The solution is different depending where the reading of EICR takes place.
>
> For ixgbe_msix_lsc() since we are in MSIX mode and know OCD is enabled a
> clear-by-write is done instead of the normal clear-by-read.
>
> For ixgbe_intr() 0xffffffff is written to EIMC before the read, masking the
> interrupts.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks.
next prev parent reply other threads:[~2009-02-21 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 22:23 [net-next PATCH 1/2] ixgbe: fix Si errata - require L0's disable on upstream device Jeff Kirsher
2009-02-21 22:23 ` [net-next PATCH 2/2] ixgbe: fix for 82598 Si errata causing buffer overflow Jeff Kirsher
2009-02-21 23:43 ` David Miller [this message]
2009-02-21 23:42 ` [net-next PATCH 1/2] ixgbe: fix Si errata - require L0's disable on upstream device David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090221.154305.237729082.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.