From: Thomas Rast <trast@student.ethz.ch>
To: Heiko Voigt <git-list@hvoigt.net>
Cc: Wincent Colaiuta <win@wincent.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] hooks: add some defaults to support sane workflow to pre-commit
Date: Sat, 21 Feb 2009 12:16:35 +0100 [thread overview]
Message-ID: <200902211216.43964.trast@student.ethz.ch> (raw)
In-Reply-To: <499FDDC2.90502@hvoigt.net>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
Heiko Voigt wrote:
> This leads me to a completely different solution to the same problem.
> How about teaching git to inherit its hooks from the parental project
> (e.g. the one it was cloned from)? That way we are not limited to
> one default behaviour but many that would match the one from the
> upstream project.
[...]
> What do you think about that?
Three words: huge security hole.
Especially on cloning, where the checkout immediately afterwards
would already run the post-checkout hook, without any chance for the
user to inspect its contents.
The usual advice is to track the hooks in the repository, e.g., under
hooks/, and instruct the users to copy them to .git/hooks/ if they
want them.
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-21 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 18:13 [RFC PATCH] hooks: add some defaults to support sane workflow to pre-commit Heiko Voigt
2009-02-20 20:49 ` Wincent Colaiuta
2009-02-21 10:56 ` Heiko Voigt
2009-02-21 11:16 ` Thomas Rast [this message]
2009-02-21 13:31 ` Heiko Voigt
2009-02-21 14:05 ` Jakub Narebski
2009-02-21 14:30 ` Heiko Voigt
2009-02-23 18:41 ` Heiko Voigt
2009-10-19 8:50 ` Junio C Hamano
2009-10-20 19:59 ` Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902211216.43964.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git-list@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.