From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Jean Delvare <khali@linux-fr.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Juergen Beisert <j.beisert@pengutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Dooks <ben-linux-arm@fluff.org>,
linux-kernel@vger.kernel.org
Subject: Re: Fwd: PCF8583 not detected on RiscPC
Date: Sun, 22 Feb 2009 01:19:36 +0100 [thread overview]
Message-ID: <20090222011936.35b21d6b@i1501.lan.towertech.it> (raw)
In-Reply-To: <20090221204147.GA25408@n2100.arm.linux.org.uk>
On Sat, 21 Feb 2009 20:41:47 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> Confirmation: reverting 02bb584f3b1cfc8188522a4d2c8881b65073a4f1 and
> removing the reference to I2C_DRIVERID_PCF8583 results in the regression
> being fixed and normal behaviour being restored.
>
> Patch below.
this is a nack on my side. the whole i2c has been converted to the
new style model. everyone is following and this is
the wrong way to fix the issue.
the device must be instantiated in the appropriate
platform code.
for an example of what needs to be done, you can grep for
i2c_board_info in arch/arm .
if you need help, just tell me where's the acorn related
platform setup code and I'll have a look.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2009-02-22 0:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 19:48 Fwd: PCF8583 not detected on RiscPC Russell King - ARM Linux
2009-02-21 20:41 ` Russell King - ARM Linux
2009-02-22 0:19 ` Alessandro Zummo [this message]
2009-02-22 8:28 ` Russell King - ARM Linux
2009-02-22 9:42 ` Alessandro Zummo
2009-02-22 9:51 ` Russell King - ARM Linux
2009-02-22 10:35 ` Alessandro Zummo
2009-02-22 11:26 ` Russell King - ARM Linux
2009-02-22 13:03 ` Alessandro Zummo
2009-02-22 9:52 ` Jean Delvare
2009-02-22 10:22 ` Russell King - ARM Linux
2009-02-22 10:40 ` Jean Delvare
2009-02-22 12:01 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090222011936.35b21d6b@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=ben-linux-arm@fluff.org \
--cc=j.beisert@pengutronix.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.