From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Teigland <teigland@redhat.com>
Date: Mon, 23 Feb 2009 12:15:30 -0600
Subject: [Cluster-devel] unfencing
In-Reply-To: <1235370440.7816.209.camel@cerberus.int.fabbione.net>
References: <20090220214431.GC23911@redhat.com>
	<1235370440.7816.209.camel@cerberus.int.fabbione.net>
Message-ID: <20090223181530.GB12791@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Mon, Feb 23, 2009 at 07:27:20AM +0100, Fabio M. Di Nitto wrote:
> > libfence:fence_node_undo(node_name) logic:
> > 	for each device_name under given node_name,
> > 	if an unfencedevice exists with name=device_name, then
> > 	run the unfencedevice agent with first arg of "undo"
> > 	and other args the normal combination of node and device args
> > 	(any agent used with unfencing must recognize/support "undo")
> 
> All our agents already support on/off enable/disable operations. It's
> probably best to align them to have the same config options rather than
> adding a new one across the board.

Yes, I have those options in mind, and would prefer to use them as well.
We'll have to wait and see during the implementation phase; for the time being
they complicate things, so I'm using "undo" to avoid those details.

(I did reuse those options back in my first unfencing attempt which I
eventually removed:
http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=c781fbb6df57f9780cdadf42126cdcc9a2ff3878)


> > <clusternode name="foo" nodeid="3">
> > 	<fence>
> > 	<method="1">
> > 		<device name="san" node="foo"/>
> > 	</method>
> > 	</fence>
> > </clusternode>
> > 
> > <fencedevices>
> > 	<fencedevice name="san" agent="fence_scsi"/>
> > </fencedevices>
> > 
> > <unfencedevices>
> > 	<unfencedevice name="san" agent="fence_scsi"/>
> > </unfencedevices>
> 
> I think that we can avoid the whole <unfence* structure either by
> overriding the default action="" for that fence method or possibly
> consider unfencing a special case method. The idea is to contain the
> whole fence config for the node within the <clusternode> object rather
> than spreading it even more.
> 
> For e.g.:
> 
> <method name="1">
>  <device name="san" node="foo"/>
> </method>
> <method name="unfence">
>  ...
> </method>
> 
> OR
> 
> <method name="1">
>  <device name="san" node="foo"/>
> </method>
> <method name="2" operation="unfence">
>  ...
> </method>
> 
> (clearly names and format are up for discussion)

The meanings of those fencing structures have never changed since being
introduced many years ago, and both of those fundamentally change it.  It
would be very unfortunate to redefine them.

A good alternative to <unfencedevices> would be an <unfence> section within
the node setions (it would not require a method level)....  Now that I've
thought more about it, it seems a better choice than "unfencedevices".  It
defines explicitly what should be done, rather than depending on the implicit
effects of matching names between fencedevice/unfencedevice.

<clusternode name="foo" nodeid="3">
	<fence>
	<method="1">
		<device name="san" node="foo"/>
	</method>
	</fence>

	<unfence>
		<device name="san" node="foo"/>
	</unfence>
</clusternode>

<fencedevices>
	<fencedevice name="san" agent="fence_scsi"/>
</fencedevices>

and

<clusternode name="bar" nodeid="4">
	<fence>
	<method="1">
		<device name="switch1" port="4"/>
		<device name="switch2" port="6"/>
	</method>
	<method="2">
		<device name="apc" port="4"/>
	</method>
	</fence>

	<unfence>
		<device name="switch1" port="4"/>
		<device name="switch1" port="6"/>
	</unfence>
</clusternode>

<fencedevices>
        <fencedevice name="switch1" agent="fence_brocade" ipaddr="1.1.1.1"/>
        <fencedevice name="switch2" agent="fence_brocade" ipaddr="2.2.2.2"/>
        <fencedevice name="apc" agent="fence_apc" ipaddr="3.3.3.3"/>
</fencedevices>

The key thing I've realized since the previous attempt in 2004, is that we
need to explicitly configure what unfencing should happen, rather than just
trying to apply the normal fencing config in reverse.

Dave