Re: [PATCH 1/2] cs553x-gpio: add AMD CS5535/CS5536 GPIO driver support

[Andres Salomon <dilinger@queued.net>]

On Tue, 24 Feb 2009 12:06:37 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 20 Feb 2009 22:12:02 -0500
> Andres Salomon <dilinger@queued.net> wrote:
> 
> > 
> > This creates a CS5535/CS5536 GPIO driver which uses a gpio_chip
> > backend (allowing GPIO users to use the generic GPIO API if
> > desired) while also allowing architecture-specific users directly
> > (via the cs553x_gpio_* functions).
> > 
> > Tested on an OLPC machine.  Some Leemotes also use CS5536 (with a
> > mips cpu), which is why this is in drivers/gpio rather than
> > arch/x86.  Currently, it conflicts with older geode GPIO support;
> > once MFGPT support is reworked to also be more generic, the older
> > geode code will be removed.
> > 
> > +EXPORT_SYMBOL_GPL(cs553x_gpio_set);
> > +EXPORT_SYMBOL_GPL(cs553x_gpio_clear);
> > +EXPORT_SYMBOL_GPL(cs553x_gpio_isset);
> 
> Nothing uses these exports.  In fact these symbols could be made
> static to drivers/gpio/cs553x-gpio.c?


Not yet.  The MFGPT, DCON, and olpc stuff will use them; I'm waiting to
hear feedback on this patch before I write a generic MFGPT driver (or
skip to cleaning up and submitting the DCON driver).