From: Dave Jones <davej@redhat.com>
To: Frans Pop <elendil@planet.nl>
Cc: Mattias-Christian Ott <ott@mirix.org>,
Dominik Brodowski <linux@brodo.de>,
Joerg Platte <jplatte@naasa.net>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
cpufreq@vger.kernel.org
Subject: Re: [PATCH] p4-clockmod: Calculate frequency based on TSC value for P4 models 0 and 1
Date: Tue, 24 Feb 2009 11:52:50 -0500 [thread overview]
Message-ID: <20090224165250.GB2998@redhat.com> (raw)
In-Reply-To: <200902240809.01312.elendil@planet.nl>
On Tue, Feb 24, 2009 at 08:08:58AM +0100, Frans Pop wrote:
> From: Mattias-Christian Ott <ott@mirix.org>
>
> Commit ed9cbcd40004904dbe61ccc16d6106a7de38c998 reverted an incorrect
> change that resulted in random frequencies being displayed in some cases
> for early P4 models because the MSR_FBC_REGISTER_ID ratio is undefined.
>
> Result of the revert is that for some users the CPU frequency is displayed
> multiplied by a factor 8 in /proc/cpuinfo when p4-clockmod is loaded.
>
> Calculating the frequency from the TSC value should work in all cases.
I already picked this up in cpufreq-next.
Additionally, it needs the chunk below.
(checkpatch also complains about the overlong line in the original
patch which I fixed up before merging).
Dave
diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h
index 2bb6a83..4f5c247 100644
--- a/arch/x86/include/asm/timer.h
+++ b/arch/x86/include/asm/timer.h
@@ -11,8 +11,8 @@ unsigned long native_calibrate_tsc(void);
#ifdef CONFIG_X86_32
extern int timer_ack;
+#endif
extern int recalibrate_cpu_khz(void);
-#endif /* CONFIG_X86_32 */
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2009-02-24 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 7:08 [PATCH] p4-clockmod: Calculate frequency based on TSC value for P4 models 0 and 1 Frans Pop
2009-02-24 16:52 ` Dave Jones [this message]
2009-02-24 17:13 ` Frans Pop
2009-02-25 3:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224165250.GB2998@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cpufreq@vger.kernel.org \
--cc=elendil@planet.nl \
--cc=jplatte@naasa.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=mjg59@srcf.ucam.org \
--cc=ott@mirix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.