From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] EXPORT_SYMBOL(d_obtain_alias) rather than EXPORT_SYMBOL_GPL Date: Tue, 24 Feb 2009 21:32:22 +0000 Message-ID: <20090224213222.GH28946@ZenIV.linux.org.uk> References: <499FA991.8080909@panasas.com> <20090221174046.GA27374@infradead.org> <20090221114015.7bb5c9d8.akpm@linux-foundation.org> <49A4547E.90607@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Andrew Morton , Christoph Hellwig , "J. Bruce Fields" , Trond Myklebust , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Benny Halevy Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:56495 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbZBXVcf (ORCPT ); Tue, 24 Feb 2009 16:32:35 -0500 In-Reply-To: <49A4547E.90607@panasas.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Feb 24, 2009 at 12:11:42PM -0800, Benny Halevy wrote: > Commit 4ea3ada2955e4519befa98ff55dd62d6dfbd1705 > declares d_obtain_alias() as EXPORT_SYMBOL_GPL > where it's supposed to replace d_alloc_anon which > was previously declared as EXPORT_SYMBOL and thus > available to any loadable module. > > This patch reverts that, as discussed below: ACK. d_obtain_alias() makes sense as a general-purpose interface, period. As an aside, EXPORT_SYMBOL_GPL() is obnoxious shite anyway. If something is not a safe API, exporting it to default-quality 3rd-party code is bad and while GPL might be many things, it is not a magical "teach average programmer to find his arse without a map" pill. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] EXPORT_SYMBOL(d_obtain_alias) rather than EXPORT_SYMBOL_GPL Date: Tue, 24 Feb 2009 21:32:22 +0000 Message-ID: <20090224213222.GH28946@ZenIV.linux.org.uk> References: <499FA991.8080909@panasas.com> <20090221174046.GA27374@infradead.org> <20090221114015.7bb5c9d8.akpm@linux-foundation.org> <49A4547E.90607@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Andrew Morton , Christoph Hellwig , "J. Bruce Fields" , Trond Myklebust , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benny Halevy Return-path: Content-Disposition: inline In-Reply-To: <49A4547E.90607-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Feb 24, 2009 at 12:11:42PM -0800, Benny Halevy wrote: > Commit 4ea3ada2955e4519befa98ff55dd62d6dfbd1705 > declares d_obtain_alias() as EXPORT_SYMBOL_GPL > where it's supposed to replace d_alloc_anon which > was previously declared as EXPORT_SYMBOL and thus > available to any loadable module. > > This patch reverts that, as discussed below: ACK. d_obtain_alias() makes sense as a general-purpose interface, period. As an aside, EXPORT_SYMBOL_GPL() is obnoxious shite anyway. If something is not a safe API, exporting it to default-quality 3rd-party code is bad and while GPL might be many things, it is not a magical "teach average programmer to find his arse without a map" pill. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html