From: Werner LEMBERG <wl@gnu.org>
To: git@vger.kernel.org
Cc: keithp@keithp.com
Subject: serious problem with `git format-patch' & `git am'
Date: Wed, 25 Feb 2009 23:03:52 +0100 (CET) [thread overview]
Message-ID: <20090225.230352.177616203.wl@gnu.org> (raw)
[both version 1.6.0.2 and git from 2009-01-24]
Folks,
I'm going to convert the FreeType CVS repository to git, using Keith
Packard's `parsecvs'. It sometimes happens that there are git entries
titled
*** empty log message ***
I want to massage the git repository before publishing it, replacing
those entries with something more meaningful.
The last time I tested this (using git 1.5.something, I no longer
remember the exact version) I did the following:
. git format-patch <start>..HEAD
git reset --hard <start>
. Edit the `Subject:' field in the created *.patch files where
necessary.
. git am --whitespace=nowarn *.patch
Unfortunately, this no longer works as before, and since I can't find
a hint in the docs about this change I wonder whether it is a bug.
With git 1.5.something, if the first paragraph of the commit message
(as output by parsecvs) looks like this
foo foo foo foo
bar bar bar bar
baz baz baz baz
it is emitted exactly as-is (after `git format-patch' & `git am');
gitk shows `foo foo foo foo' as the first line. However, git version
1.6.0.2 and the current git both convert newlines to spaces in the
first paragraph! I now get
foo foo foo foo bar bar bar bar baz baz baz baz
as the beginning of the commit message which is VERY bad since
CVS-style entries often have a long first paragraph, causing
ugly-looking, overlong lines.
In case this is an intended change I ask you urgently to provide an
option to get back the old behaviour of `git format-patch' & `git am'.
Werner
next reply other threads:[~2009-02-25 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 22:03 Werner LEMBERG [this message]
2009-02-26 10:42 ` serious problem with `git format-patch' & `git am' Johannes Schindelin
2009-02-26 18:00 ` Brandon Casey
2009-02-27 1:11 ` Jakub Narebski
2009-02-27 2:10 ` Junio C Hamano
2009-02-27 15:47 ` Brandon Casey
2009-02-27 17:53 ` Junio C Hamano
2009-02-27 9:16 ` Werner LEMBERG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225.230352.177616203.wl@gnu.org \
--to=wl@gnu.org \
--cc=git@vger.kernel.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.