From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [Bugme-new] [Bug 12754] New: inotify doesn't free memory
	allocated to watches
Date: Wed, 25 Feb 2009 00:28:33 +0000
Message-ID: <20090225002833.GK28946@ZenIV.linux.org.uk>
References: <bug-12754-10286@http.bugzilla.kernel.org/> <20090224130523.f6c4c450.akpm@linux-foundation.org> <20090224213800.GI28946@ZenIV.linux.org.uk> <20090224232337.GJ28946@ZenIV.linux.org.uk> <20090224154023.c003c35c.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: russell@rickstewart.com, bugme-daemon@bugzilla.kernel.org,
	linux-fsdevel@vger.kernel.org, john@johnmccutchan.com,
	rlove@rlove.org
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:35733 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752969AbZBYA2m (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 24 Feb 2009 19:28:42 -0500
Content-Disposition: inline
In-Reply-To: <20090224154023.c003c35c.akpm@linux-foundation.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Feb 24, 2009 at 03:40:23PM -0800, Andrew Morton wrote:
> ./Documentation/filesystems/inotify.txt
> ./kernel/audit.c
> ./kernel/audit_tree.c
> ./fs/notify/inotify/inotify_user.c
> ./fs/notify/inotify/inotify.c
> ./include/linux/inotify.h
> 
> I assume it's inotify_dev_queue_event()?
> 
>         if (mask & IN_IGNORED || w->mask & IN_ONESHOT)
>                 put_inotify_watch(w); /* final put */

Duh.  Nevermind, I'd misparsed the report.  If we are talking about
inotify_user.c (and not some new client), then we are back to "let's
see what gets leaked"...

Actually, looking at inotify_user.c, we seem to be doing something rather
fishy.  Look: event gets triggered, we pick the watch, get inotify_device
(inotify_user-specific stuff) from it, grap mutex on it (dev->ev_mutex)
and drop reference to inotify_watch.  Which happily triggers ->destroy_watch,
which does put_inotify_dev().  Which is
        if (atomic_dec_and_test(&dev->count)) {
                atomic_dec(&dev->user->inotify_devs);
                free_uid(dev->user);
                kfree(dev);
        }
What's to stop that from happening when we'd been holding the last reference
to that sucker?  kfree() while holding a mutex inside the structure being
freed is not nice...