[U-Boot] [PATCH/next branch] powerpc: Only use eth_getenv_enetaddr() if networking is enabled

[Stefan Roese <sr@denx.de>]

On Wednesday 25 February 2009, Wolfgang Denk wrote:
> > +++ b/lib_ppc/board.c
> > @@ -888,8 +888,10 @@ void board_init_r (gd_t *id, ulong dest_addr)
> >  		bd->bi_ethspeed = 0xFFFF;
> >  #endif
> >
> > +#ifdef CONFIG_CMD_NET
> >  	/* kept around for legacy kernels only ... ignore the next section */
> >  	eth_getenv_enetaddr("ethaddr", bd->bi_enetaddr);
> > +#endif
> >  #ifdef CONFIG_HAS_ETH1
> >  	eth_getenv_enetaddr("eth1addr", bd->bi_enet1addr);
> >  #endif
>
> Should that #ifdef not include the code for "eth1addr" etc., too?

I don't think this is needed. If a board has a 2nd (or 3rd...) ethernet 
interface, it sets CONFIG_HAS_ETH1. I can't think of a board setting this 
define and not enabling CONFIG_CMD_NET.

But if you prefer it, I could change the patch to include all eth interfaces 
in the #ifdef CONFIG_CMD_NET part. Just let me know.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================