From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] tracing/core: introduce per cpu tracing files
Date: Wed, 25 Feb 2009 14:02:02 +0100 [thread overview]
Message-ID: <20090225130202.GH26273@elte.hu> (raw)
In-Reply-To: <49a4e2c1.0508d00a.21e6.2eea@mx.google.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Impact: split up tracing output per cpu
> So this patch creates a new directory inside /debug/tracing
> (provided you have a debugfs mountpoint on /debug). Inside
> this directory, you will now find one trace_pipe file, one
> trace file and one latency_trace file per cpu. Which means if
> you have two cpus, you will have:
>
> trace0
> trace1
> trace_pipe0
> trace_pipe1
Very nice! I've applied your patches to tip:tracing/ftrace.
Could you please do one more tweak? The /debug/tracing/per_cpu/
directory looks a bit cluttered on a 16-way box. It would be a
nicer structure to have per CPU directories, i.e.:
/debug/tracing/per_cpu/cpu0/trace
/debug/tracing/per_cpu/cpu0/trace_pipe
/debug/tracing/per_cpu/cpu1/trace
/debug/tracing/per_cpu/cpu1/trace_pipe
etc.
Besides being easier to handle, this also makes it easy to
extend the list of per CPU attributes as well, without
cluttering the /debug/tracing/per_cpu/ directory.
Ingo
next prev parent reply other threads:[~2009-02-25 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 2:22 [PATCH 1/2] tracing/core: introduce per cpu tracing files Frederic Weisbecker
2009-02-25 13:02 ` Ingo Molnar [this message]
2009-02-25 16:13 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225130202.GH26273@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.