From: ccaulfield@sourceware.org <ccaulfield@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW daemons/clvmd/clvmd-corosync.c
Date: 25 Feb 2009 14:33:02 -0000 [thread overview]
Message-ID: <20090225143302.4435.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: ccaulfield at sourceware.org 2009-02-25 14:33:01
Modified files:
. : WHATS_NEW
daemons/clvmd : clvmd-corosync.c
Log message:
Fix error returns in clvmd-corosync interface to DLM.
Thanks to Xinwei Hu for spotting this.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1053&r2=1.1054
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-corosync.c.diff?cvsroot=lvm2&r1=1.5&r2=1.6
--- LVM2/WHATS_NEW 2009/02/25 13:17:40 1.1053
+++ LVM2/WHATS_NEW 2009/02/25 14:33:00 1.1054
@@ -1,5 +1,6 @@
Version 2.02.45 -
===================================
+ Fix error returns in clvmd-corosync interface to DLM.
Add --refresh to vgchange and vgmknodes man pages.
Fixed bug where lvresize option -t was not properly passed to fsadm.
Using argv[] list in exec_cmd() to allow more params for external commands.
--- LVM2/daemons/clvmd/clvmd-corosync.c 2009/02/11 10:13:20 1.5
+++ LVM2/daemons/clvmd/clvmd-corosync.c 2009/02/25 14:33:01 1.6
@@ -478,6 +478,12 @@
DEBUGLOG("dlm_ls_lock returned %d\n", errno);
return err;
}
+ if (lksb.sb_status != 0)
+ {
+ DEBUGLOG("dlm_ls_lock returns lksb.sb_status %d\n", lksb.sb_status);
+ errno = lksb.sb_status;
+ return -1;
+ }
DEBUGLOG("lock_resource returning %d, lock_id=%x\n", err, lksb.sb_lkid);
@@ -504,6 +510,13 @@
DEBUGLOG("Unlock returned %d\n", err);
return err;
}
+ if (lksb.sb_status != 0)
+ {
+ DEBUGLOG("dlm_ls_unlock_wait returns lksb.sb_status: %d\n", lksb.sb_status);
+ errno = lksb.sb_status;
+ return -1;
+ }
+
return 0;
}
@@ -568,7 +581,7 @@
confdb_handle_t handle;
int result;
int namelen = buflen;
- unsigned int cluster_handle;
+ hdb_handle_t cluster_handle;
confdb_callbacks_t callbacks = {
.confdb_key_change_notify_fn = NULL,
.confdb_object_create_change_notify_fn = NULL,
next reply other threads:[~2009-02-25 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 14:33 ccaulfield [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-03 13:42 LVM2 ./WHATS_NEW daemons/clvmd/clvmd-corosync.c ccaulfield
2009-04-01 7:51 ccaulfield
2009-03-06 11:29 ccaulfield
2009-02-10 13:22 ccaulfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225143302.4435.qmail@sourceware.org \
--to=ccaulfield@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.