From: Felipe Balbi <me@felipebalbi.com>
To: Bryan Wu <cooloney@kernel.org>
Cc: felipe.balbi@nokia.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH] usb: musb: - kill the compile warning
Date: Wed, 25 Feb 2009 20:16:12 +0200 [thread overview]
Message-ID: <20090225181611.GL31792@frodo> (raw)
In-Reply-To: <1233915810-18616-1-git-send-email-cooloney@kernel.org>
On Fri, Feb 06, 2009 at 06:23:30PM +0800, Bryan Wu wrote:
> drivers/usb/musb/musb_core.c:1433: warning: assignment makes pointer
> from integer without a cast
> hw_ep->target_regs = musb_read_target_reg_base(i, mbase);
>
> static inline u16 musb_read_target_reg_base(u8 i, void __iomem *mbase);
>
> this is a common bug, but a bug still ? mbase is a 32/64 bit pointer,
> but we return a u16 to assign to a pointer ? seems odd :)
>
> So return right pointer in the stub.
>
> Cc: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
any new version coming ??
--
balbi
next prev parent reply other threads:[~2009-02-25 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 10:23 [PATCH] usb: musb: - kill the compile warning Bryan Wu
2009-02-06 18:24 ` Felipe Balbi
2009-02-12 6:03 ` David Brownell
2009-02-12 10:55 ` Felipe Balbi
2009-02-12 20:30 ` David Brownell
2009-02-25 18:16 ` Felipe Balbi [this message]
2009-02-27 22:37 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225181611.GL31792@frodo \
--to=me@felipebalbi.com \
--cc=cooloney@kernel.org \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.