Re: [patch 0/7] Use strict kernel types to fix the world

[Arnd Bergmann <arnd@arndb.de>]

On Thursday 26 February 2009, H. Peter Anvin wrote:
> I'm really of two minds regarding the patches that replace pure data 
> types (2/7-5/7).  Part of me thinks it would be better to do this via a 
> script in make headers_install, but another part of me thinks that that 
> is a recipe for missing includes.
> 
> However, if subsystem maintainers are sharing headers with other 
> platforms, it's probably the only sane road to go.

The only file I found that is obviously shared across operating systems
is linux/coda.h, and I completely left that one alone on the basis
that the hacks in there should still work with the new linux/types.h.

Doing an automated conversion on coda.h would guarantee trouble, which
I see as an argument for doing the manual approach in general.

The changes outside of mtd, netfilter, drm and pfkeyv2.h are actually
pretty minimal. For reference, all other patches touching those files
since 2.6.28 have a combined diffstat of 

 include/drm/drm.h                      |   26 +++-
 include/drm/drm_mode.h                 |  271 ++++++++++++++++++++++++++++++++
 include/drm/i915_drm.h                 |   43 +++++-
 include/linux/agpgart.h                |    1 -
 include/linux/cyclades.h               |    2 -
 include/linux/dvb/audio.h              |    5 -
 include/linux/dvb/video.h              |    7 +-
 include/linux/if_pppol2tp.h            |    2 +-
 include/linux/matroxfb.h               |    2 +-
 include/linux/mroute6.h                |   26 +++-
 include/linux/netfilter/x_tables.h     |    2 +-
 include/linux/netfilter/xt_conntrack.h |    1 +
 include/linux/pkt_sched.h              |   18 ++
 include/linux/ppp_defs.h               |    2 +
 include/linux/time.h                   |    1 +
 include/linux/types.h                  |   24 ++--
 include/linux/xfrm.h                   |   14 ++
 include/mtd/inftl-user.h               |    2 +
 include/mtd/ubi-user.h                 |  134 +++++++++++++---
 include/sound/asound.h                 |    1 +
 20 files changed, 530 insertions(+), 54 deletions(-)

As long as the netfilter, mtd and drm maintainers agree, I don't see
anything holding up the convert-everything-now approach.

	Arnd <><