From: Frederic Weisbecker <fweisbec@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 1/4] uaccess: add copy_word_from_user
Date: Thu, 26 Feb 2009 03:10:32 +0100 [thread overview]
Message-ID: <20090226021031.GA7553@nowhere> (raw)
In-Reply-To: <49A5F81F.6060604@zytor.com>
On Wed, Feb 25, 2009 at 06:02:07PM -0800, H. Peter Anvin wrote:
> Steven Rostedt wrote:
>> This patch creates a copy_word_from_user function that can copy
>> a space delimited word from user space. This puts the code in
>> a new lib/uaccess.c file. This keeps the code in a single location
>> and may be optimized in the future.
>
> I have a bit of an issue with the naming... at least *I* read this as
> copying a machine word, which made me wonder why you didn't just use
> "get_user". I would suggest copy_token_from_user or something like that.
>
> -hpa
That was the first impression I had too (the sense of a machine word).
But token seems to me imprecise as well, too much generic.
Well, since it is well commented, I guess it's not so much an issue...
next prev parent reply other threads:[~2009-02-26 2:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 20:30 [PATCH 0/4] [git pull] for tip/tracing/ftrace Steven Rostedt
2009-02-25 20:30 ` [PATCH 1/4] uaccess: add copy_word_from_user Steven Rostedt
2009-02-25 21:39 ` Andrew Morton
2009-02-25 22:00 ` Steven Rostedt
2009-02-25 22:18 ` [PATCH][git pull] uaccess: add example to copy_word_from_user in comment Steven Rostedt
2009-02-25 21:40 ` [PATCH 1/4] uaccess: add copy_word_from_user Frederic Weisbecker
2009-02-25 21:54 ` Andrew Morton
2009-02-25 23:56 ` Andrew Morton
2009-02-26 1:46 ` Steven Rostedt
2009-02-26 5:34 ` Andrew Morton
2009-02-26 2:02 ` H. Peter Anvin
2009-02-26 2:10 ` Frederic Weisbecker [this message]
2009-02-26 2:13 ` H. Peter Anvin
2009-02-26 2:17 ` Steven Rostedt
2009-02-26 2:18 ` H. Peter Anvin
2009-02-26 5:36 ` Andrew Morton
2009-02-26 5:43 ` Steven Rostedt
2009-02-25 20:30 ` [PATCH 2/4] tracing: convert event_trace to use copy_word_from_user Steven Rostedt
2009-02-25 20:30 ` [PATCH 3/4] tracing: convert ftrace_regex_write " Steven Rostedt
2009-02-25 20:30 ` [PATCH 4/4] tracing: convert ftrace_graph_write " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226021031.GA7553@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.