From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: remove update_apic from x86_quirks
Date: Thu, 26 Feb 2009 06:32:54 +0100 [thread overview]
Message-ID: <20090226053254.GA11806@elte.hu> (raw)
In-Reply-To: <49A61FA9.5080706@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
>
> Impact: cleanup
>
> x86_quirks->update_apic() calling looks crazy. so try to remove it
> 1. every apic take wakeup_cpu member directly
> 2. seperate es7000_apic to es7000_apic_cluster
> 3. use uv_wakeup_cpu directly
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> arch/x86/include/asm/apic.h | 7 +
> arch/x86/include/asm/setup.h | 3
> arch/x86/include/asm/uv/uv.h | 3
> arch/x86/kernel/apic/apic_flat_64.c | 4 -
> arch/x86/kernel/apic/bigsmp_32.c | 2
> arch/x86/kernel/apic/es7000_32.c | 127 ++++++++++++++++++++++++++--------
> arch/x86/kernel/apic/numaq_32.c | 10 --
> arch/x86/kernel/apic/probe_32.c | 16 ----
> arch/x86/kernel/apic/probe_64.c | 3
> arch/x86/kernel/apic/summit_32.c | 2
> arch/x86/kernel/apic/x2apic_cluster.c | 2
> arch/x86/kernel/apic/x2apic_phys.c | 2
> arch/x86/kernel/apic/x2apic_uv_x.c | 11 +-
> arch/x86/kernel/setup.c | 14 ---
> arch/x86/kernel/smpboot.c | 8 --
> 15 files changed, 121 insertions(+), 93 deletions(-)
that's certainly a nice cleanup! Applied to tip:x86/apic, thanks
Yinghai!
Ingo
next prev parent reply other threads:[~2009-02-26 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 4:50 [PATCH] x86: remove update_apic from x86_quirks Yinghai Lu
2009-02-26 5:32 ` Ingo Molnar [this message]
2009-02-26 5:34 ` Ingo Molnar
2009-02-26 5:43 ` Ingo Molnar
2009-02-26 8:20 ` Yinghai Lu
2009-02-26 11:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226053254.GA11806@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.