From: Andrew Morton <akpm@linux-foundation.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: sameo@openedhand.com, linux-kernel@vger.kernel.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] mfd: Use the value of the final spin when reading the AUXADC
Date: Thu, 26 Feb 2009 14:25:16 -0800 [thread overview]
Message-ID: <20090226142516.fdef29b5.akpm@linux-foundation.org> (raw)
In-Reply-To: <1235579015-16193-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On Wed, 25 Feb 2009 16:23:35 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm8350-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index a285cc0..c2be308 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -1111,7 +1111,7 @@ int wm8350_read_auxadc(struct wm8350 *wm8350, int channel, int scale, int vref)
> do {
> schedule_timeout_interruptible(1);
> reg = wm8350_reg_read(wm8350, WM8350_DIGITISER_CONTROL_1);
> - } while (--tries && (reg & WM8350_AUXADC_POLL));
> + } while ((reg & WM8350_AUXADC_POLL) && --tries);
>
> if (!tries)
> dev_err(wm8350->dev, "adc chn %d read timeout\n", channel);
Please do not ever send any unchangelogged patches ever again, at all, ever.
OK?
next prev parent reply other threads:[~2009-02-26 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 16:23 [PATCH 1/2] mfd: Add support for WM8351 revision B Mark Brown
2009-02-25 16:23 ` [PATCH 2/2] mfd: Use the value of the final spin when reading the AUXADC Mark Brown
2009-02-26 22:25 ` Andrew Morton [this message]
2009-02-26 16:15 ` [PATCH 1/2] mfd: Add support for WM8351 revision B Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2009-03-03 15:53 Mark Brown
2009-03-03 15:53 ` [PATCH 2/2] mfd: Use the value of the final spin when reading the AUXADC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226142516.fdef29b5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.