From: Andrew Morton <akpm@linux-foundation.org>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
eric@lammerts.org
Subject: Re: [PATCH][retry 2] Conform L3 Cache Index Disable to Linux standards From: Eric Lammerts <eric@lammerts.org>
Date: Thu, 26 Feb 2009 16:33:29 -0800 [thread overview]
Message-ID: <20090226163329.3a47b368.akpm@linux-foundation.org> (raw)
In-Reply-To: <200902201550.47415.mark.langsdorf@amd.com>
On Fri, 20 Feb 2009 15:50:47 -0600
Mark Langsdorf <mark.langsdorf@amd.com> wrote:
> Add ABI Documentation entry and fix some /sys directory formating
> issues with the L3 Cache Index Disable feature for future AMD
> processors. __Add a check to disable it for family 0x10 models
> that do not support it yet.
x86_64 allnoconfig:
arch/x86/kernel/cpu/intel_cacheinfo.c:556: warning: 'free_cache_attributes' defined but not used
arch/x86/kernel/cpu/intel_cacheinfo.c:596: warning: 'detect_cache_attributes' defined but not used
Fixing these revealed another shower of unused functions. Fixing those
led to an even bigger shower.
Obviously, the code is a mess and needs some thought, understanding and
restructuring so that mere mortals can correctly modify it.
I'll drop the patches. Please test version 3 a bit better?
next prev parent reply other threads:[~2009-02-27 0:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 21:50 [PATCH][retry 2] Conform L3 Cache Index Disable to Linux standards From: Eric Lammerts <eric@lammerts.org> Mark Langsdorf
2009-02-20 22:46 ` Andrew Morton
2009-02-27 0:33 ` Andrew Morton [this message]
2009-02-27 8:02 ` Ingo Molnar
2009-03-02 16:44 ` [PATCH][retry 2] Conform L3 Cache Index Disable to Linuxstandards " Langsdorf, Mark
2009-03-02 20:02 ` Ingo Molnar
2009-03-03 22:14 ` [PATCH][retry 3] " Mark Langsdorf
2009-03-03 22:22 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226163329.3a47b368.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=eric@lammerts.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.