From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg KH <greg@kroah.com>
Subject: Re: [Staging/p9auth] Feb 26 Next: build failure
Date: Thu, 26 Feb 2009 09:42:43 -0800
Message-ID: <20090226174243.GC23465@kroah.com>
References: <20090226193022.adb78235.sfr@canb.auug.org.au> <49A67892.8060006@in.ibm.com> <20090226155355.GA22194@kroah.com> <49A6CA74.7000809@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-next-owner@vger.kernel.org>
Received: from kroah.org ([198.145.64.141]:42882 "EHLO coco.kroah.org"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1751783AbZBZRq0 (ORCPT <rfc822;linux-next@vger.kernel.org>);
	Thu, 26 Feb 2009 12:46:26 -0500
Content-Disposition: inline
In-Reply-To: <49A6CA74.7000809@oracle.com>
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "Sachin P. Sant" <sachinp@in.ibm.com>, Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, ashwin.ganti@gmail.com

On Thu, Feb 26, 2009 at 08:59:32AM -0800, Randy Dunlap wrote:
> Greg KH wrote:
> > On Thu, Feb 26, 2009 at 04:40:10PM +0530, Sachin P. Sant wrote:
> >> Feb 26 Next tree randconfig build fails with
> >>
> >> drivers/staging/p9auth/p9auth.c: In function cap_write:
> >> drivers/staging/p9auth/p9auth.c:249: error: implicit declaration of 
> >> function current_uid
> >> drivers/staging/p9auth/p9auth.c:261: error: implicit declaration of 
> >> function prepare_creds
> >> drivers/staging/p9auth/p9auth.c:261: warning: assignment makes pointer from 
> >> integer without a cast
> >> drivers/staging/p9auth/p9auth.c:266: error: dereferencing pointer to 
> >> incomplete type
> >> drivers/staging/p9auth/p9auth.c:267: error: dereferencing pointer to 
> >> incomplete type
> >> drivers/staging/p9auth/p9auth.c:268: error: implicit declaration of 
> >> function commit_creds
> >> make[3]: *** [drivers/staging/p9auth/p9auth.o] Error 1
> > 
> > Wierd, I thought cred.h would be pulled in with the current include
> > files.
> 
> Even if it were, that's not what we want.  We want explicit #includes
> for macros or structs etc. that are used in a source file.
> 
> > With this .config, if you add:
> > 	#include <linux/cred.h>
> > to drivers/staging/p9auth/p9auth.c does it solve the build error?
> > 
> > I'll go add it just to be safe :)
> 
> It needs both cred.h and sched.h in my testing.

Now done, it will show up in tomorrow's -next tree.

thanks,

greg k-h