From: Ralf Baechle <ralf@linux-mips.org>
To: Mark Asselstine <mark.asselstine@windriver.com>
Cc: linux-mips@linux-mips.org, oprofile-list@lists.sf.net
Subject: Re: [PATCH] oprofile: VR5500 performance counter driver
Date: Thu, 26 Feb 2009 17:49:07 +0000 [thread overview]
Message-ID: <20090226174907.GA1222@linux-mips.org> (raw)
In-Reply-To: <1235406394-2650-1-git-send-email-mark.asselstine@windriver.com>
On Mon, Feb 23, 2009 at 11:26:34AM -0500, Mark Asselstine wrote:
> +static int vr5500_perfcount_handler(void)
> +{
> + unsigned int control;
> + unsigned int counter;
> + int handled = IRQ_NONE;
> + unsigned int counters = NUM_COUNTERS;
> +
> + if (cpu_has_mips_r2 && !(read_c0_cause() & (1 << 26)))
> + return handled;
The Vr5500 is no R2 processor so these two lines are dead code.
Ralf
prev parent reply other threads:[~2009-02-26 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 16:26 [PATCH] oprofile: VR5500 performance counter driver Mark Asselstine
2009-02-25 16:59 ` Robert Richter
2009-02-26 16:30 ` M. Asselstine
2009-02-26 17:07 ` Robert Richter
2009-02-26 17:51 ` Ralf Baechle
2009-02-26 20:49 ` [PATCH V2] " Mark Asselstine
2009-03-03 11:07 ` Robert Richter
2009-03-04 17:53 ` M. Asselstine
2009-03-04 21:50 ` Robert Richter
2009-06-23 9:29 ` Robert Richter
2009-02-26 17:49 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226174907.GA1222@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.asselstine@windriver.com \
--cc=oprofile-list@lists.sf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.