From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757640AbZBZUdT (ORCPT ); Thu, 26 Feb 2009 15:33:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753537AbZBZUdD (ORCPT ); Thu, 26 Feb 2009 15:33:03 -0500 Received: from verein.lst.de ([213.95.11.210]:37529 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbZBZUdB (ORCPT ); Thu, 26 Feb 2009 15:33:01 -0500 Date: Thu, 26 Feb 2009 21:32:51 +0100 From: Christoph Hellwig To: torvalds@osdl.org Cc: Takashi Sato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [hch: [PATCH] fix FREEZE/THAW compat_ioctl regression] Message-ID: <20090226203251.GA31003@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.28i X-Spam-Score: -0.001 () BAYES_44,UPPERCASE_25_50 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [I sent this 10 days ago to lkml and fsdevel and didn't get a single reply yet, can we please get this in so we don't have that regression in 2.6.29?] Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW handling in xfs_compat_ioctl but never added any compat handler back, so now any freeze/thaw request from a 32-bit binary ond 64-bit userspace will fail. As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL entries in fs/compat_ioctl.c will do the job. Signed-off-by: Christoph Hellwig Index: xfs/fs/compat_ioctl.c =================================================================== --- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000 +++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000 @@ -1913,6 +1913,9 @@ /* 0x00 */ COMPATIBLE_IOCTL(FIBMAP) COMPATIBLE_IOCTL(FIGETBSZ) +/* 'X' - originally XFS but some now in the VFS */ +COMPATIBLE_IOCTL(FIFREEZE) +COMPATIBLE_IOCTL(FITHAW) /* RAID */ COMPATIBLE_IOCTL(RAID_VERSION) COMPATIBLE_IOCTL(GET_ARRAY_INFO) ----- End forwarded message -----