From: Jeremy Higdon <jeremy@sgi.com>
To: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Cc: jesse.barnes@intel.com, habeck@sgi.com
Subject: [PATCH 1/1] Fix PCI DMA flag propagation on SN (Altix) with PICs
Date: Fri, 27 Feb 2009 01:38:35 -0800 [thread overview]
Message-ID: <20090227093835.GA306198@sgi.com> (raw)
We recently discovered a problem with passing of DMA attributes on
SN systems with the older PIC chips.
Signed-off-by: Jeremy Higdon <jeremy@sgi.com>
--- a/arch/ia64/sn/pci/pcibr/pcibr_dma.c 2009-02-25 23:29:21.000000000 -0800
+++ b/arch/ia64/sn/pci/pcibr/pcibr_dma.c 2009-02-25 23:29:09.318611870 -0800
@@ -135,11 +135,10 @@ pcibr_dmatrans_direct64(struct pcidev_in
if (SN_DMA_ADDRTYPE(dma_flags) == SN_DMA_ADDR_PHYS)
pci_addr = IS_PIC_SOFT(pcibus_info) ?
PHYS_TO_DMA(paddr) :
- PHYS_TO_TIODMA(paddr) | dma_attributes;
+ PHYS_TO_TIODMA(paddr);
else
- pci_addr = IS_PIC_SOFT(pcibus_info) ?
- paddr :
- paddr | dma_attributes;
+ pci_addr = paddr;
+ pci_addr |= dma_attributes;
/* Handle Bus mode */
if (IS_PCIX(pcibus_info))
next reply other threads:[~2009-02-27 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 9:38 Jeremy Higdon [this message]
2009-02-27 19:08 ` [PATCH 1/1] Fix PCI DMA flag propagation on SN (Altix) with PICs Jesse Barnes
2009-02-27 19:21 ` Matthew Wilcox
2009-02-27 19:21 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090227093835.GA306198@sgi.com \
--to=jeremy@sgi.com \
--cc=habeck@sgi.com \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.