All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alina Friedrichsen" <x-alina@gmx.net>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: IBSS issues
Date: Fri, 27 Feb 2009 11:19:11 +0100	[thread overview]
Message-ID: <20090227101911.291200@gmx.net> (raw)
In-Reply-To: <18855.45396.45156.609477@gargle.gargle.HOWL>

Hi Sujith!

> Yep, that is the problem. But that chunk of code (and the bug) has be=
en
> there forever,
> so am not sure why it is creating a problem now.

Maybe because the scanning code was changed? But I have discovered this=
 bug at the end of the last year before the scanning code was changed t=
he last time.

> And it can be fixed by
> making use of the scan start/stop mac80211 callbacks.

I think a much cleaner way would be if the ath9k_hw_write_associd() hon=
or the FIF_BCN_PRBRESP_PROMISC flag and determine with it if sc->curbss=
id should be set or ath_bcast_mac. So the the old sc->curbssid setting =
is saved. And then remove the following code...

if (*total_flags & FIF_BCN_PRBRESP_PROMISC) {
        memcpy(sc->curbssid, ath_bcast_mac, ETH_ALEN);
        sc->curaid =3D 0;

=2E..so that ath9k_hw_write_associd() is called if the FIF_BCN_PRBRESP_=
PROMISC is cleared at the end of the scanning, too. So that it can set =
the BSSID in the hardware back to sc->curbssid.

Regards
Alina

--=20
Psssst! Schon vom neuen GMX MultiMessenger geh=F6rt? Der kann`s mit all=
en: http://www.gmx.net/de/go/multimessenger01
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-02-27 10:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-27  4:04 IBSS issues Sujith
2009-02-27  8:25 ` Alina Friedrichsen
2009-02-27  8:44   ` Sujith
2009-02-27  9:53     ` Alina Friedrichsen
2009-02-27 10:14       ` Sujith
2009-02-27 10:56         ` Alina Friedrichsen
2009-02-27  9:01   ` Alina Friedrichsen
2009-02-27  9:24     ` Sujith
2009-02-27 10:19       ` Alina Friedrichsen [this message]
2009-02-27 10:32         ` Sujith
2009-02-27 11:02           ` Alina Friedrichsen
2009-02-27 21:53           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090227101911.291200@gmx.net \
    --to=x-alina@gmx.net \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.