From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Jens Gehrlein <sew_s-77yLcl8UjJQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Guennadi Liakhovetski <lg-ynQEQJNshbs@public.gmane.org>,
a.paterniani-03BXCEkGbFHYGGNLXY5/rw@public.gmane.org,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org
Subject: Re: [RFC PATCH V2] generic SPI driver for all i.MX-platforms
Date: Fri, 27 Feb 2009 11:39:46 +0100 [thread overview]
Message-ID: <20090227103946.GD3481@pengutronix.de> (raw)
In-Reply-To: <49A78AF3.1000606-77yLcl8UjJQ@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]
> Do I understand it right: the driver has a bug, not the CPU?
Well, CPOL=0 means zero based polarity, no? The refman states for POL:
"0 = Active high polarity (0idle)". Now, look at the FSL-driver:
if (!(spi->mode & SPI_CPOL))
ctrl_reg |=
spi_ver_def->mode_mask << spi_ver_def->
low_pol_shift;
Looks to me that the '!' is mixing things up here. This is why SPI
devices from the FSL-BSP usually have SPI_MODE_2, although SPI_MODE_0 is
the common thing.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 415 bytes --]
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
[-- Attachment #3: Type: text/plain, Size: 210 bytes --]
_______________________________________________
spi-devel-general mailing list
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
prev parent reply other threads:[~2009-02-27 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 16:21 [RFC PATCH V2] generic SPI driver for all i.MX-platforms Wolfram Sang
[not found] ` <1235665315-2792-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-02-26 16:37 ` Wolfram Sang
[not found] ` <20090226163721.GD3058-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-02-27 6:40 ` Jens Gehrlein
[not found] ` <49A78AF3.1000606-77yLcl8UjJQ@public.gmane.org>
2009-02-27 10:39 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090227103946.GD3481@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=a.paterniani-03BXCEkGbFHYGGNLXY5/rw@public.gmane.org \
--cc=lg-ynQEQJNshbs@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
--cc=sew_s-77yLcl8UjJQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.