From: "Daniel P. Berrange" <berrange@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PATCH: 8/9: Support ACLs for controlling VNC access
Date: Fri, 27 Feb 2009 10:42:04 +0000 [thread overview]
Message-ID: <20090227104204.GC23877@redhat.com> (raw)
In-Reply-To: <49A712B1.20704@us.ibm.com>
On Thu, Feb 26, 2009 at 04:07:45PM -0600, Anthony Liguori wrote:
> >
> >
> > Makefile | 6 +-
> > b/acl.c | 168
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > b/acl.h | 74 ++++++++++++++++++++++++
> > monitor.c | 95 +++++++++++++++++++++++++++++++
> > vnc-auth-sasl.c | 16 ++++-
> > vnc-auth-sasl.h | 7 ++
> > vnc-tls.c | 19 ++++++
> > vnc-tls.h | 3 +
> > vnc.c | 14 ++++
> > vnc.h | 3 +
> > 10 files changed, 398 insertions(+), 7 deletions(-)
> >
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> >
>
> This breaks the win32 build. Attached are the make and config logs.
> I'm using the F10 mingw packages fwiw.
Ahh, I see one of the Windows system headers define a type called
'ACL' already, so I'll have to adjust that.
> CC vnc.o
> In file included from /home/anthony/git/qemu/vnc-tls.h:34,
> from /home/anthony/git/qemu/vnc.h:79,
> from /home/anthony/git/qemu/vnc.c:27:
> /home/anthony/git/qemu/acl.h:31: error: conflicting types for 'ACL'
> /usr/i686-pc-mingw32/sys-root/mingw/include/winnt.h:1834: error: previous declaration of 'ACL' was here
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
next prev parent reply other threads:[~2009-02-27 10:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 11:39 [Qemu-devel] PATCH: 0/9: Support SASL authentication in VNC server (version 3) Daniel P. Berrange
2009-02-26 11:52 ` [Qemu-devel] PATCH: 1/9: Fix bug in TLS authenticataion Daniel P. Berrange
2009-02-26 11:52 ` [Qemu-devel] PATCH: 2/9: Enhance 'info vnc' monitor output Daniel P. Berrange
2009-02-26 11:53 ` [Qemu-devel] PATCH: 3/9: Refactor keymap code to avoid duplication Daniel P. Berrange
2009-02-26 11:53 ` [Qemu-devel] PATCH: 4/9: Move VNC structs into header file Daniel P. Berrange
2009-02-26 11:55 ` [Qemu-devel] PATCH: 5/9: Move TLS auth into separate file Daniel P. Berrange
2009-02-26 11:56 ` [Qemu-devel] PATCH: 6/9: Add SASL authentication support Daniel P. Berrange
2009-02-26 18:57 ` Blue Swirl
2009-02-26 20:33 ` Daniel P. Berrange
2009-02-26 21:34 ` Anthony Liguori
2009-02-27 10:46 ` Daniel P. Berrange
2009-02-27 11:14 ` John Haxby
2009-02-26 11:56 ` [Qemu-devel] PATCH: 7/9: Include auth credentials in 'info vnc' Daniel P. Berrange
2009-02-26 11:57 ` [Qemu-devel] PATCH: 8/9: Support ACLs for controlling VNC access Daniel P. Berrange
2009-02-26 22:05 ` Anthony Liguori
2009-02-26 22:07 ` Anthony Liguori
2009-02-27 10:42 ` Daniel P. Berrange [this message]
2009-02-26 11:57 ` [Qemu-devel] PATCH: 9/9: Persist ACLs in external files Daniel P. Berrange
-- strict thread matches above, loose matches on Subject: below --
2009-03-02 12:31 [Qemu-devel] PATCH: 0/9: Support SASL authentication in VNC server (version 4) Daniel P. Berrange
2009-03-02 12:42 ` [Qemu-devel] PATCH: 8/9: Support ACLs for controlling VNC access Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090227104204.GC23877@redhat.com \
--to=berrange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.