From: "Yang, Sheng" <sheng.yang@intel.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "kvm-devel" <kvm@vger.kernel.org>
Subject: Re: assigned dev msi int handling
Date: Fri, 27 Feb 2009 12:26:44 +0800 [thread overview]
Message-ID: <200902271226.44756.sheng.yang@intel.com> (raw)
In-Reply-To: <20090226235927.GA4270@amt.cnet>
On Friday 27 February 2009 07:59:27 Marcelo Tosatti wrote:
> Hi Sheng,
>
> So for guest INTX interrupts the host interrupt is reenabled on ack from
> the guest, which is nice. Now for guest MSI interrupts it keeps reenabling
> the interrupt as fast as the work handler can run.
>
> Can you explain why it works this way? Why not disable interrupts
> on the host in all cases and only reenable on ack?
>
Sorry for I didn't think it over... The direct reason is ack_irq binding with
kvm_set_irq() which is unnecessary for MSI/MSI-X. But enable(msi) after EOI
seems more proper here, though more changes are needed for MSI-X(seems we need
one ack notifier for one vector in MSI-X).
--
regards
Yang, Sheng
prev parent reply other threads:[~2009-02-27 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 23:59 assigned dev msi int handling Marcelo Tosatti
2009-02-27 4:26 ` Yang, Sheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902271226.44756.sheng.yang@intel.com \
--to=sheng.yang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.