From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LdNi7-0002o7-Ik for mharc-grub-devel@gnu.org; Sat, 28 Feb 2009 06:50:27 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LdNi5-0002mH-01 for grub-devel@gnu.org; Sat, 28 Feb 2009 06:50:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LdNi2-0002lk-Rn for grub-devel@gnu.org; Sat, 28 Feb 2009 06:50:23 -0500 Received: from [199.232.76.173] (port=51270 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdNi2-0002lU-7X for grub-devel@gnu.org; Sat, 28 Feb 2009 06:50:22 -0500 Received: from aybabtu.com ([69.60.117.155]:38500) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LdNi1-0001Wz-Pc for grub-devel@gnu.org; Sat, 28 Feb 2009 06:50:21 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LdNam-0001MO-H6 for grub-devel@gnu.org; Sat, 28 Feb 2009 12:42:54 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LdNhq-0005lw-Me for grub-devel@gnu.org; Sat, 28 Feb 2009 12:50:10 +0100 Date: Sat, 28 Feb 2009 12:50:10 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090228115010.GA22149@thorin> References: <49A91C92.2030708@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49A91C92.2030708@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Possible improvements to build system X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2009 11:50:25 -0000 On Sat, Feb 28, 2009 at 12:14:26PM +0100, phcoder wrote: > 2. ata.mod, hdparm.mod, ata_pthru.mod, usbms.mod, ohci.mod, uhci.mod, > usbtest.mod, usb.mod, memdisk.mod > I don't see why these modules are in i386-pc.rmk and not in common.rmk This is because nobody implemented grub_in* and grub_out* functions on powerpc. But in the meantime, they could move to i386.rmk. As for memdisk, it used to depend on the image format (thus PE had to be excluded), but IIRC this is not so anymore. It could move to common.rmk. > 3. kernel.img, grub-setup > These contain a number of files shared by all platforms. Like e.g. > filesystems. I propose to create an additional file common-pre.rmk which > could contain the variables like > FS_files=... > which platform-specific files can use later This is trickier than it seems. Many of the gen* scripts parse those files and changing them this way would break stuff. It needs to be done carefully. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."