From: Daniel Mack <daniel@caiaq.de>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] cs4270: add support for slave mode configurations
Date: Sat, 28 Feb 2009 18:47:13 +0100 [thread overview]
Message-ID: <20090228174713.GA20813@buzzloop.caiaq.de> (raw)
In-Reply-To: <ed82fe3e0902280832u2a6e907l8195b5d9b00eafa2@mail.gmail.com>
Hi Timur,
On Sat, Feb 28, 2009 at 10:32:30AM -0600, Timur Tabi wrote:
> On Sat, Feb 28, 2009 at 6:13 AM, Daniel Mack <daniel@caiaq.de> wrote:
> > Hmm - mclk bits are set with 'reg |= cs4270_mode_ratios[i].mclk;'
> > unconditionally, and both speed flags are used when in slave mode. Don't
> > see where you suspect a flaw here?
>
> I think the code is fine, my question is more about the behavior of
> the hardware. We were never able to get our board to run reliably
> with the cs4270 in slave mode, so I never gave it much thought. I was
> hoping you could explain why you still need to set the mclk bits in
> the mode register when you're in slave mode.
We use the CS4270 in many projects (external soundcards) and in some of
them, we even link up to four of them together and put them all to slave
mode which works perfectly fine. It's just the first time I use it on a
Linux based board, though.
Setting the MCLKs for slave mode is probably not necessary (the
datesheet says so, too), but it doesn't harm either. We're doing that
for our other applications, so I copied the behaviour. In general, I
can says that this codec is a very smoothly working piece of hardware,
we never had any hazzle with it and use it for years now - what are the
effects that you see?
Daniel
next prev parent reply other threads:[~2009-02-28 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 13:37 [PATCH] cs4270: add support for slave mode configurations Daniel Mack
2009-02-25 15:34 ` Mark Brown
2009-02-25 15:45 ` Daniel Mack
2009-02-25 15:48 ` Mark Brown
2009-02-27 21:51 ` Timur Tabi
2009-02-28 12:13 ` Daniel Mack
2009-02-28 16:32 ` Timur Tabi
2009-02-28 17:47 ` Daniel Mack [this message]
2009-03-01 1:09 ` Timur Tabi
2009-02-28 12:21 ` [PATCH] fix typo and removed unneeded switch case Daniel Mack
2009-03-01 1:11 ` Timur Tabi
2009-03-02 14:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090228174713.GA20813@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=alsa-devel@alsa-project.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.