From: Frederic Weisbecker <fweisbec@gmail.com>
To: Luis Henriques <henrix@sapo.pt>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] tracing: remove unused code
Date: Sat, 28 Feb 2009 20:54:33 +0100 [thread overview]
Message-ID: <20090228195431.GA6574@nowhere> (raw)
In-Reply-To: <20090228194004.GA9780@hades.domain.com>
On Sat, Feb 28, 2009 at 07:40:04PM +0000, Luis Henriques wrote:
> On Sat, Feb 28, 2009 at 08:21:37AM +0100, Ingo Molnar wrote:
> >
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > Thanks Luis,
> > >
> > > But before I remove this code, I want to move it to be
> > > activated by tracing options. The irqsoff tracer (and other
> > > latency tracers) are pretty useless without it.
> >
> > sounds good.
>
> Ok, understood. I am sorry for the noise introduced by this patch... I should
> have got some more context before submitting it -- I am really not that familiar
> with this code and tried just to remove a compile warning without fully
> understand the whole picture :-)
Don't be sorry, the fix was right.
But nobody can be aware of all background history in a subsystem, unless one read
all tracing related posts but it is very active these time so it can be a little pain for
a newcomer.
> --
> Luis Henriques
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2009-02-28 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 20:29 [PATCH -tip] tracing: remove unused code Luis Henriques
2009-02-27 20:36 ` Steven Rostedt
2009-02-28 7:21 ` Ingo Molnar
2009-02-28 19:40 ` Luis Henriques
2009-02-28 19:54 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090228195431.GA6574@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=henrix@sapo.pt \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.