From: Theodore Tso <tytso@mit.edu>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Mark Brown <broonie@sirena.org.uk>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies
Date: Sat, 28 Feb 2009 19:18:29 -0500 [thread overview]
Message-ID: <20090301001829.GA10751@mit.edu> (raw)
In-Reply-To: <49A9C252.50204@s5r6.in-berlin.de>
On Sun, Mar 01, 2009 at 12:01:38AM +0100, Stefan Richter wrote:
> > As I have previously said, that is not the case in reality. There
> > appears to be substantial sentiment among people handling patches that
> > not having any text in the body of the e-mail makes it harder to handle
> > patches.
>
> It is indeed a problem
> - if the patch title alone insufficiently describes the patch
> or
> - if a patch reviewer believes that it is OK to ignore patch titles.
Worse yet, if we start getting these sorts of entries being returned
by "git log":
------------
ext4: Fix spelling error: successfull
Fix spelling error: successfull
Signed-off-by: "Trivial Patch Submitter" <spelling@nits.org>
------------
Just to shut up checkpatch, I'm going to feel the urge to shake a
checkpatch maintainer warmly by the throat.
Sometimes, all that is needed is:
------------
ext4: Fix spelling error: successfull
Signed-off-by: "Trivial Patch Submitter" <spelling@nits.org>
------------
- Ted
next prev parent reply other threads:[~2009-03-01 0:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 18:05 [PATCH] checkpatch: Warn on empty commit log bodies Mark Brown
2009-02-28 13:58 ` Stefan Richter
2009-02-28 15:58 ` Mark Brown
2009-02-28 16:14 ` Stefan Richter
2009-02-28 16:46 ` Mark Brown
2009-02-28 17:33 ` Stefan Richter
2009-02-28 17:52 ` Mark Brown
2009-02-28 19:25 ` Stefan Richter
2009-02-28 21:02 ` Mark Brown
2009-02-28 23:01 ` Stefan Richter
2009-03-01 0:18 ` Theodore Tso [this message]
2009-03-01 0:46 ` Mark Brown
2009-03-01 2:53 ` Theodore Tso
2009-03-02 13:15 ` Mark Brown
2009-03-02 15:15 ` Stefan Richter
2009-03-02 16:01 ` Mark Brown
2009-03-02 18:01 ` Andrew Morton
2009-03-02 18:24 ` Mark Brown
2009-03-02 18:34 ` Andrew Morton
2009-03-02 18:43 ` Theodore Tso
2009-03-02 19:19 ` Mark Brown
2009-03-02 19:57 ` Theodore Tso
2009-03-02 20:38 ` Mark Brown
2009-03-10 18:19 ` Andy Whitcroft
2009-02-28 17:40 ` Arjan van de Ven
2009-02-28 17:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090301001829.GA10751@mit.edu \
--to=tytso@mit.edu \
--cc=apw@canonical.com \
--cc=broonie@sirena.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.