From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
alexander.h.duyck@intel.com, mitch.a.williams@intel.com
Subject: Re: [net-next PATCH v2] igb: remove skb_orphan calls
Date: Mon, 02 Mar 2009 16:02:01 -0800 (PST) [thread overview]
Message-ID: <20090302.160201.56279333.davem@davemloft.net> (raw)
In-Reply-To: <20090302234337.12241.52123.stgit@lost.foo-projects.org>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 02 Mar 2009 15:44:04 -0800
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> Remove skb_orphan call from igb driver as it can cause multiple issues due
> to the fact that it is calling the desctructor and removing the skb from
> the socket prior to transmission.
>
> The call was added to improve performance but did so by allowing the skb to
> be removed from the socket which gave the socket more window space to
> transmit. The performance gain is not worth the extra problems that this
> kind of workaround can introduce as this could lead to a potential DoS if a
> UDP stream decided to monopolize the transmit path.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Acked-by: Mitch Williams <mitch.a.williams@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2009-03-03 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 23:44 [net-next PATCH v2] igb: remove skb_orphan calls Jeff Kirsher
2009-03-03 0:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302.160201.56279333.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.