Re: [PATCH] lkdtm: reduce stack size

[Ankita Garg <ankita@in.ibm.com>]

Hi Bernd,

On Mon, Mar 02, 2009 at 10:51:30AM +0100, Bernd Petrovitsch wrote:
> Hi!
> 
> On Mon, 2009-03-02 at 09:41 +0530, Ankita Garg wrote:
> > Hi Frank,
> > 
> > On Sun, Mar 01, 2009 at 09:00:14PM +0100, Frank Seidel wrote:
> > > From: Frank Seidel <frank@f-seidel.de>
> > > 
> > > Reduce stack memory footprint of lkdtm
> > > (recursive_loop). From 1024 bytes on i386 down
> > > to <10.
> > >
> > 
> > The intention here is infact to trigger a stack overflow. This module is
> > used to test kernel dumping mechanism like kdump. So the expectation is
> > that the kernel will dump as soon as the stack overflows.
> 
> That answers why the variable exists at all. It is only zeroed and never
> else used.
> Hmm, adding the above as a comment makes probably sense.
>

There is some text at the head of the module file that explains what the
module does and the usage, etc. I suppose that would be sufficient ?
 
-- 
Regards,
Ankita Garg (ankita@in.ibm.com)
Linux Technology Center
IBM India Systems & Technology Labs, 
Bangalore, India