From: David Miller <davem@davemloft.net>
To: roel.kluin@gmail.com
Cc: paul.moore@hp.com, netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] cipso: subtraction on unsigned hdr_delta
Date: Tue, 03 Mar 2009 23:42:08 -0800 (PST) [thread overview]
Message-ID: <20090303.234208.199560892.davem@davemloft.net> (raw)
In-Reply-To: <49ADADEA.8090306@gmail.com>
From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 03 Mar 2009 23:23:38 +0100
> hdr_delta is unsigned, so take care not to subtract below 0.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
I'd like Paul to look at this.
It looks like it does the wrong thing when the option space increases,
which would have made hdr_delta negative if it were of a signed type.
I think therefore that sk_conn->icsk_ext_hdr_len needs to be adjusted
in both directions, just just when the option area length shrinks.
next prev parent reply other threads:[~2009-03-04 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 22:23 [PATCH] cipso: subtraction on unsigned hdr_delta Roel Kluin
2009-03-04 7:42 ` David Miller [this message]
2009-03-04 17:25 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303.234208.199560892.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.