From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH mainline] menu: fix embedded menu snafu
Date: Tue, 3 Mar 2009 01:30:31 +0100 [thread overview]
Message-ID: <20090303003031.GC4147@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.00.0903021619270.3111@localhost.localdomain>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, 2 Mar 2009, Andrew Morton wrote:
> >
> > This patch causes weird unintended breakage, methinks.
>
> Damn, you're right. It looked obvious, so I already applied it, but I
> clearly shouldn't have.
>
> The whole "if EMBEDDED" thing is totally wrong, because those config
> options very much_do_ exist even when non-embedded, it's just that then
> they always take their default valies.
>
> Thanks for noticing.
probably also explains weird build breakages i've been getting
since i updated to your latest:
CC kernel/futex.o
In file included from kernel/futex.c:61:
kernel/rtmutex_common.h: In function ‘task_has_pi_waiters’:
kernel/rtmutex_common.h:81: error: ‘struct task_struct’ has no
member named ‘pi_waiters’
kernel/rtmutex_common.h: In function ‘task_top_pi_waiter’:
kernel/rtmutex_common.h:87: error: ‘struct task_struct’ has no
member named ‘pi_waiters’
make[1]: *** [kernel/futex.o] Error 1
Ingo
next prev parent reply other threads:[~2009-03-03 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 22:14 [PATCH mainline] menu: fix embedded menu snafu Randy Dunlap
2009-03-03 0:16 ` Andrew Morton
2009-03-03 0:21 ` Linus Torvalds
2009-03-03 0:30 ` Ingo Molnar [this message]
2009-03-03 0:35 ` [PATCH v2] " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303003031.GC4147@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.