From: Mark Brown <broonie@sirena.org.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Lopez Cruz, Misael" <x0052729@ti.com>
Subject: Re: [PATCH] ASoC: Add GPIO support for jack reporting interface
Date: Tue, 3 Mar 2009 11:16:40 +0000 [thread overview]
Message-ID: <20090303111640.GC27155@sirena.org.uk> (raw)
In-Reply-To: <s5h63irp0qb.wl%tiwai@suse.de>
On Tue, Mar 03, 2009 at 07:41:16AM +0100, Takashi Iwai wrote:
> I prefer GPIO stuff built in conditionally.
> The jack layer is used also for non-ASoC codes, and GPIO isn't always
> present.
This is the jack wrapper in sound/soc rather in the generic sound/core
version so it should be safe to have it in unconditionally (I'd be
surprised if an ASoC platform didn't have gpiolib support), though
there's no harm in making it conditional on gpiolib either.
next prev parent reply other threads:[~2009-03-03 11:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 1:05 [PATCH] ASoC: Add GPIO support for jack reporting interface Lopez Cruz, Misael
2009-03-03 6:41 ` Takashi Iwai
2009-03-03 11:16 ` Mark Brown [this message]
2009-03-03 11:23 ` Takashi Iwai
2009-03-03 18:39 ` Lopez Cruz, Misael
2009-03-03 18:42 ` Mark Brown
2009-03-03 18:54 ` Lopez Cruz, Misael
2009-03-03 11:14 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2009-03-03 21:25 Lopez Cruz, Misael
2009-03-04 14:43 ` Mark Brown
2009-03-04 14:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303111640.GC27155@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
--cc=x0052729@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.