From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Coding style in sensors daemon (sensord)
Date: Wed, 04 Mar 2009 09:16:59 +0000 [thread overview]
Message-ID: <20090304101659.55fa8bd6@hyperion.delvare> (raw)
In-Reply-To: <20090304091128.GA4632@ubuntu>
Hallo Andre,
On Wed, 4 Mar 2009 10:11:29 +0100, Andre Prendel wrote:
> looking at the source code in prog/sensord I've seen gnu coding
> style. IMO this is really hard to read. In sensors/ and dump/ we are
> using the kernel style and I prefer this one.
>
> To be consistent and ease reading and fixing, I will spend some time
> to bring the sensord code in shape.
>
> Any objections?
No objections, please go ahead. sensord was contributed by Merlin
Hughes a long time ago, and while I (and others) spent a significant
amount of time cleaning up the coding style of other parts of the code,
sensord didn't receive too much love over the past few years... Just
the minimum to keep it alive. You are very welcome to improve the
sensord code, be it the style or the code itself.
Thanks,
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-03-04 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 9:11 [lm-sensors] Coding style in sensors daemon (sensord) Andre Prendel
2009-03-04 9:16 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304101659.55fa8bd6@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.