From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] [retry] vt: add ioctl commands to /dev/vcsaN to get/put the current palette of the given tty Date: Wed, 4 Mar 2009 14:16:35 -0800 Message-ID: <20090304141635.fa756831.akpm@linux-foundation.org> References: <427911.793301236157128303.JavaMail.root@spooler2-g27.priv.proxad.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <427911.793301236157128303.JavaMail.root-u0VDug3vKOpsFmKuirFwRhh1pbbyJDp15NbjCUgZEJk@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Cedric Roux Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org, mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Wed, 4 Mar 2009 09:58:48 +0100 (CET) Cedric Roux wrote: > From: Cedric Roux > > A ioctl interface and two ioctl commands added to /dev/vcsaN > to get/put the current palette of the given tty. > > ... > > - lock_kernel() is called. Maybe it's not necessary? I'm not > confident enough. You decide. I wouldn't have a clue what it's protecting in there. But it seems sane to put it in - once someone gets down and de-lock_kernel()s that code, they can work out what it should be replaced by. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755421AbZCDWRA (ORCPT ); Wed, 4 Mar 2009 17:17:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752067AbZCDWQt (ORCPT ); Wed, 4 Mar 2009 17:16:49 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38053 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbZCDWQs (ORCPT ); Wed, 4 Mar 2009 17:16:48 -0500 Date: Wed, 4 Mar 2009 14:16:35 -0800 From: Andrew Morton To: Cedric Roux Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk, mtk.manpages@gmail.com, linux-api@vger.kernel.org Subject: Re: [PATCH] [retry] vt: add ioctl commands to /dev/vcsaN to get/put the current palette of the given tty Message-Id: <20090304141635.fa756831.akpm@linux-foundation.org> In-Reply-To: <427911.793301236157128303.JavaMail.root@spooler2-g27.priv.proxad.net> References: <427911.793301236157128303.JavaMail.root@spooler2-g27.priv.proxad.net> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Mar 2009 09:58:48 +0100 (CET) Cedric Roux wrote: > From: Cedric Roux > > A ioctl interface and two ioctl commands added to /dev/vcsaN > to get/put the current palette of the given tty. > > ... > > - lock_kernel() is called. Maybe it's not necessary? I'm not > confident enough. You decide. I wouldn't have a clue what it's protecting in there. But it seems sane to put it in - once someone gets down and de-lock_kernel()s that code, they can work out what it should be replaced by.