From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LeyZQ-0002Zx-Lp for mharc-grub-devel@gnu.org; Wed, 04 Mar 2009 16:24:04 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LeyZO-0002YD-GC for grub-devel@gnu.org; Wed, 04 Mar 2009 16:24:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LeyZM-0002Vr-MG for grub-devel@gnu.org; Wed, 04 Mar 2009 16:24:01 -0500 Received: from [199.232.76.173] (port=40881 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeyZM-0002Vi-Cj for grub-devel@gnu.org; Wed, 04 Mar 2009 16:24:00 -0500 Received: from aybabtu.com ([69.60.117.155]:43469) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LeyZM-0008LJ-2d for grub-devel@gnu.org; Wed, 04 Mar 2009 16:24:00 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LeyRk-0002C4-GY for grub-devel@gnu.org; Wed, 04 Mar 2009 22:16:09 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LeyZI-0008DQ-W4 for grub-devel@gnu.org; Wed, 04 Mar 2009 22:23:56 +0100 Date: Wed, 4 Mar 2009 22:23:56 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090304212356.GL31201@thorin> References: <20090304163509.GA26106@riva.ucam.org> <20090304211629.GJ31201@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090304211629.GJ31201@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Support up to 256 SCSI disks on Linux X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2009 21:24:02 -0000 On Wed, Mar 04, 2009 at 10:16:29PM +0100, Robert Millan wrote: > > else if (major == SCSI_DISK0_MAJOR) > > - sprintf (name, "/dev/sd%c", 'a' + minor / 16); > > + grub_util_getdiskname_scsi (name, 0, minor / 16); > > + else if (major == SCSI_DISK1_MAJOR) > > + grub_util_getdiskname_scsi (name, 1, minor / 16); > > [...] > > Can this be factorized somehow? Space in raid.mod is quite critical; when > used it usually ends up in core.img, which needs to fit in the embed area. Oh, I'm sorry. I thought you were editting disk/raid.c. util/raid.c has no size issues. A macro would still be nice though. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."