All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH] Make coreutils 6.x+ install utility to honor STRIP env	variable
Date: Wed, 4 Mar 2009 15:50:32 -0800	[thread overview]
Message-ID: <20090304235032.GA29159@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

Hi

As reported in bug 5052 and also on irc, install calls strip directly. We should make it use STRIP
env variable which is set to <cross-strip> in OE env.

This is a patch which does that

OK for .dev ?

Thx
-Khem



[-- Attachment #2: coreutils-install-use-STRIP.patch --]
[-- Type: text/x-diff, Size: 858 bytes --]

Index: coreutils-6.0/src/install.c
===================================================================
--- coreutils-6.0.orig/src/install.c	2009-03-04 15:37:45.000000000 -0800
+++ coreutils-6.0/src/install.c	2009-03-04 15:38:57.000000000 -0800
@@ -526,7 +526,14 @@
 strip (char const *name)
 {
   int status;
-  pid_t pid = fork ();
+  pid_t pid;
+  char *strip_name;
+
+  strip_name = getenv ("STRIP");
+  if (strip_name == NULL)
+    strip_name = "strip";
+
+  pid = fork ();
 
   switch (pid)
     {
@@ -534,7 +541,7 @@
       error (EXIT_FAILURE, errno, _("fork system call failed"));
       break;
     case 0:			/* Child. */
-      execlp ("strip", "strip", name, NULL);
+      execlp (strip_name, "strip", name, NULL);
       error (EXIT_FAILURE, errno, _("cannot run strip"));
       break;
     default:			/* Parent. */

             reply	other threads:[~2009-03-04 23:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04 23:50 Khem Raj [this message]
2009-03-05  0:59 ` [PATCH] Make coreutils 6.x+ install utility to honor STRIP env variable Michael 'Mickey' Lauer
2009-03-05 10:21 ` Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090304235032.GA29159@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.