Re: [PATCH] fix DMI for EFI

[Ingo Molnar <mingo@elte.hu>]

* Huang Ying <ying.huang@intel.com> wrote:

> On Thu, 2009-03-05 at 01:54 +0800, Ingo Molnar wrote:
> > * Brian Maly <bmaly@redhat.com> wrote:
> > 
> > >
> > >
> > >> Hm, could we ever find ourselves in the positition of having to access 
> > >> the DMI strings table in the EFI init code, to implement a quirk? I 
> > >> think that's quite plausible.
> > >
> > >> OTOH, with some DMI quirks in EFI tables it's a bit of a chicken and 
> > >> egg problem. Can DMI strings ever be outside of EFI tables on EFI 
> > >> systems?
> > >
> > >> 	Ingo
> > >
> > > Right now it is EFI that loads the dmi tables (and all other 
> > > tables such as ACPI), so it is a chicken and the egg. I think 
> > > that if dmi is ever needed by EFI, the dmi scan will have to 
> > > be moved inside efi_init. We could move the dmi scan into 
> > > efi_init and do the dmi scan the moment we have the dmi table. 
> > > Thats really the soonest point we could scan on EFI systems. 
> > > Im OK with moving dmi to efi_init if you prefer.
> > 
> > Your patch looks fine, but i'd like to hear the opinion of Ying 
> > Huang as well.
> 
> This patch is OK for me.

thanks. There are two EFI patches queued up for .29:

dd39ecf: x86: EFI: Back efi_ioremap with init_memory_mapping instead of FIX_MAP
ff0c087: x86: fix DMI on EFI

	Ingo