All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "George G. Davis" <gdavis@mvista.com>
Cc: linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] ARM: OMAP2: Fix missing system control module exports
Date: Thu, 5 Mar 2009 16:43:09 -0800	[thread overview]
Message-ID: <20090306004309.GG6784@atomide.com> (raw)
In-Reply-To: <20090302144723.GD18140@mvista.com>

Hi,

* George G. Davis <gdavis@mvista.com> [090302 08:19]:
> When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based
> targets, the build fails because omap_ctrl_{read,write}l lack exports.
> So add the missing exports for omap_ctrl_{read,write}[bwl] to allow
> building these ASoC (and other) drivers as modules.

I think Paul has some comments on how the clock framework should
handle this case without needing to export the omap_ctrl_read/write.

Regards,

Tony
 
> Signed-off-by: George G. Davis <gdavis@mvista.com>
> Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> ---
>  arch/arm/mach-omap2/control.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
> index 5f3aad9..6b14639 100644
> --- a/arch/arm/mach-omap2/control.c
> +++ b/arch/arm/mach-omap2/control.c
> @@ -36,29 +36,35 @@ u8 omap_ctrl_readb(u16 offset)
>  {
>  	return __raw_readb(OMAP_CTRL_REGADDR(offset));
>  }
> +EXPORT_SYMBOL(omap_ctrl_readb);
>  
>  u16 omap_ctrl_readw(u16 offset)
>  {
>  	return __raw_readw(OMAP_CTRL_REGADDR(offset));
>  }
> +EXPORT_SYMBOL(omap_ctrl_readw);
>  
>  u32 omap_ctrl_readl(u16 offset)
>  {
>  	return __raw_readl(OMAP_CTRL_REGADDR(offset));
>  }
> +EXPORT_SYMBOL(omap_ctrl_readl);
>  
>  void omap_ctrl_writeb(u8 val, u16 offset)
>  {
>  	__raw_writeb(val, OMAP_CTRL_REGADDR(offset));
>  }
> +EXPORT_SYMBOL(omap_ctrl_writeb);
>  
>  void omap_ctrl_writew(u16 val, u16 offset)
>  {
>  	__raw_writew(val, OMAP_CTRL_REGADDR(offset));
>  }
> +EXPORT_SYMBOL(omap_ctrl_writew);
>  
>  void omap_ctrl_writel(u32 val, u16 offset)
>  {
>  	__raw_writel(val, OMAP_CTRL_REGADDR(offset));
>  }
> +EXPORT_SYMBOL(omap_ctrl_writel);
>  
> -- 
> 1.6.1.2.MVISTA
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-03-06  0:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-02 14:47 [PATCH] ARM: OMAP2: Fix missing system control module exports George G. Davis
2009-03-06  0:43 ` Tony Lindgren [this message]
2009-03-06  2:31   ` George G. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090306004309.GG6784@atomide.com \
    --to=tony@atomide.com \
    --cc=gdavis@mvista.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.